Page MenuHomeFreeBSD
Differential D51680

kyua: Stop using readdir_r()
ClosedPublic
Actions

Authored by des on Fri, Aug 1, 4:17 PM.
Tags
None
Referenced Files
F125418969: D51680.diff
Thu, Aug 7, 3:06 PM
Unknown Object (File)
Wed, Aug 6, 9:05 PM
Unknown Object (File)
Wed, Aug 6, 9:05 PM
Unknown Object (File)
Mon, Aug 4, 6:56 AM
Unknown Object (File)
Mon, Aug 4, 4:37 AM
Unknown Object (File)
Mon, Aug 4, 4:27 AM
Unknown Object (File)
Mon, Aug 4, 4:13 AM
Unknown Object (File)
Mon, Aug 4, 3:51 AM
View All 11 Files
Subscribers
emaste
igoro
imp

Details

Reviewers
igoro
Group Reviewers
Klara
Commits
rG65bae451c23b: kyua: Stop using readdir_r()
Summary

It cannot be used safely, and Kyua doesn't even pretend to try.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Fri, Aug 1, 4:17 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 1, 4:17 PM
des requested review of this revision.Fri, Aug 1, 4:17 PM
Harbormaster completed remote builds in B65897: Diff 159580.Fri, Aug 1, 4:17 PM
des added a parent revision: D51679: libarchive: Stop using readdir_r().Fri, Aug 1, 4:17 PM
des added a child revision: D51681: libc: Deprecate readdir_r().
des updated this revision to Diff 159606.Fri, Aug 1, 10:35 PM

bogus free

Harbormaster completed remote builds in B65908: Diff 159606.Fri, Aug 1, 10:35 PM
igoro accepted this revision.Fri, Aug 1, 10:56 PM
igoro added a subscriber: igoro.

LGTM

contrib/kyua/utils/fs/directory.cpp
197

It seems it needs renaming to readdir not to let message readers think that readder_r was on the case.

This revision is now accepted and ready to land.Fri, Aug 1, 10:56 PM
des marked an inline comment as done.Fri, Aug 1, 11:08 PM
des updated this revision to Diff 159608.Fri, Aug 1, 11:10 PM

exception

This revision now requires review to proceed.Fri, Aug 1, 11:10 PM
Harbormaster completed remote builds in B65910: Diff 159608.Fri, Aug 1, 11:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Aug 1, 11:14 PM
Closed by commit rG65bae451c23b: kyua: Stop using readdir_r() (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: rG65bae451c23b: kyua: Stop using readdir_r().
emaste added a subscriber: emaste.Fri, Aug 1, 11:25 PM

Also needs to be added to https://github.com/freebsd/kyua

des added a comment.Fri, Aug 1, 11:53 PM
In D51680#1180679, @emaste wrote:

Also needs to be added to https://github.com/freebsd/kyua

See https://github.com/freebsd/kyua/commit/5d4df8e30bad13106c2ae58efad9bcb55659fc9e

Revision Contents
Changeset List

PathSize
contrib/
kyua/
utils/
fs/
18 lines

Diff 159611

View Options

contrib/kyua/utils/fs/directory.cpp

Loading...