Differential D51651

LinuxKPI: pci: fix argument type to linuxkpi_pci_iomap[_range]
ClosedPublic
Actions

Authored by bz on Thu, Jul 31, 7:18 AM.

Tags

None

Referenced Files

	F126697273: D51651.diff
	Fri, Aug 22, 6:33 PM

	Unknown Object (File)
	Thu, Aug 21, 6:37 AM

	Unknown Object (File)
	Wed, Aug 20, 8:51 PM

	Unknown Object (File)
	Tue, Aug 19, 4:00 PM

	Unknown Object (File)
	Thu, Aug 14, 5:34 PM

	Unknown Object (File)
	Tue, Aug 12, 8:15 AM

	Unknown Object (File)
	Mon, Aug 11, 11:49 AM

	Unknown Object (File)
	Sat, Aug 2, 7:19 AM

View All 9 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG421bf3a96867: LinuxKPI: pci: fix argument type to linuxkpi_pci_iomap[_range]

Summary

The last argument (maxlen) to linuxkpi_pci_iomap_range and
linuxkpi_pci_iomap is an unsigned long not an int. LinuxKPI is
not using that argument in the end but fix it where needed.
While here adjust the name to 'maxlen' and remove the "mmio_" to
bar and off.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 65861
Build 62744: arc lint + arc unit

Event Timeline

bz created this revision.Thu, Jul 31, 7:18 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptThu, Jul 31, 7:19 AM

bz requested review of this revision.Thu, Jul 31, 7:19 AM

Harbormaster completed remote builds in B65861: Diff 159487.Thu, Jul 31, 7:19 AM

emaste accepted this revision.Thu, Jul 31, 10:21 AM

This revision is now accepted and ready to land.Thu, Jul 31, 10:21 AM

bz added inline comments.Thu, Jul 31, 5:10 PM

sys/compat/linuxkpi/common/src/linux_pci.c
806	Forgot to bring this over from the larger change; will be part of the commit. s/mimo_off/off/

Closed by commit rG421bf3a96867: LinuxKPI: pci: fix argument type to linuxkpi_pci_iomap[_range] (authored by bz). · Explain WhyThu, Jul 31, 5:39 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG421bf3a96867: LinuxKPI: pci: fix argument type to linuxkpi_pci_iomap[_range].

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

8 lines

src/

16 lines

Diff 159487

sys/compat/linuxkpi/common/include/linux/pci.h

Loading...

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...