It hasn't worked for some time -- as reported in review D40816 "Installing FreeBSD with Auto ZFS + MBR has been broken ever since the move to OpenZFS with FreeBSD 13." It relied on the partition table and ZFS data overlapping in a very fragile way and is not a good idea.
Details
Details
- Reviewers
jhb - Commits
- rGee110941e35c: bsdinstall: Remove support for ZFS + MBR disk layouts
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| usr.sbin/bsdinstall/scripts/zfsboot | ||
|---|---|---|
| 1674 | ||
Comment Actions
If you want to remove it outright, that's probably a bigger change? I would say we should probably remove it entirely from bsdinstall, then probably stop building the non-GPT zfsboot as well.
Comment Actions
We will probably want a general RELNOTES entry at some point about removing ZFS MBR boot support?
Comment Actions
A few more stragglers. I would maybe reword the commit log as "bsdinstall: Remove support for ZFS + MBR disk layouts".
Note that this means you can't use ZFS + MBR on a non-booting disk, but that seems ok to me. There's no good reason to do that anyway. You can always use the raw disk or GPT on non-boot disks.
| usr.sbin/bsdinstall/scripts/zfsboot | ||
|---|---|---|
| 828 | ||
Comment Actions
Hmm, my suggestion to remove the invocation of sysctl kern.geom.part.mbr.enforce_chs=0 wasn't posted, but that should be removed as well.