Page MenuHomeFreeBSD
Differential D51491

db/hash.c: Do not return an error when opening a missing database with O_CREAT
ClosedPublic
Actions

Authored by bnovkov on Jul 24 2025, 3:52 PM.
Tags
None
Referenced Files
F153496670: D51491.diff
Tue, Apr 21, 11:36 AM
Unknown Object (File)
Sun, Apr 19, 7:24 AM
Unknown Object (File)
Sun, Apr 5, 9:28 AM
Unknown Object (File)
Sat, Apr 4, 3:47 AM
Unknown Object (File)
Wed, Apr 1, 8:43 PM
Unknown Object (File)
Wed, Apr 1, 11:23 AM
Unknown Object (File)
Wed, Apr 1, 2:55 AM
Unknown Object (File)
Wed, Mar 25, 9:27 AM
View All 44 Files
Subscribers
imp

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG108e2d1137aa: db/hash.c: Do not return an error when opening a missing database with O_CREAT
Summary

dbm_open currently returns an error when opening a missing database
with O_CREAT but creates the request database file. This is caused
by a buggy check in __hash_open which attempts to detect a new
(or empty) database file, but fails to take the O_CREAT flag into
account.

Fix this by expanding the check to include O_CREAT.

Fixes: edcdc752ecdd
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65655
Build 62538: arc lint + arc unit

Revision Contents
Changeset List

PathSize
lib/
libc/
db/
hash/
3 lines

Diff 159007

View Options

lib/libc/db/hash/hash.c

Loading...