Differential D51450

qlnxe: Fix advertising the IFCAP_LINKSTATE capability
ClosedPublic
Actions

Authored by zlei on Jul 21 2025, 10:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 8 2026, 5:27 AM

	Unknown Object (File)
	Feb 8 2026, 4:33 AM

	Unknown Object (File)
	Jan 31 2026, 12:19 PM

	Unknown Object (File)
	Jan 12 2026, 12:51 PM

	Unknown Object (File)
	Dec 14 2025, 12:44 AM

	Unknown Object (File)
	Dec 12 2025, 5:08 AM

	Unknown Object (File)
	Nov 28 2025, 7:52 PM

	Unknown Object (File)
	Nov 17 2025, 8:49 AM

View All 36 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGad08006c7fd5: qlnxe: Fix advertising the IFCAP_LINKSTATE capability
rGcdd97f3aacf1: qlnxe: Fix advertising the IFCAP_LINKSTATE capability
rGc18860339d50: qlnxe: Fix advertising the IFCAP_LINKSTATE capability

Summary

The following up advertising of IFCAP_HWCSUM capability unconditionally
overwrite IFCAP_LINKSTATE.

MFC after: 3 days

Test Plan

Before the change,

# ifconfig ql0
ql0: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
	options=507bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,LRO,VLAN_HWFILTER,VLAN_HWTSO>

After the change,

# ifconfig ql0
ql0: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
	options=8d07bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,TSO4,TSO6,LRO,VLAN_HWFILTER,VLAN_HWTSO,LINKSTATE>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Jul 21 2025, 10:48 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 21 2025, 10:48 AM

zlei requested review of this revision.Jul 21 2025, 10:48 AM

kbowling accepted this revision.Jul 21 2025, 11:21 AM

This revision is now accepted and ready to land.Jul 21 2025, 11:21 AM

Closed by commit rGc18860339d50: qlnxe: Fix advertising the IFCAP_LINKSTATE capability (authored by zlei). · Explain WhyJul 22 2025, 4:11 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGc18860339d50: qlnxe: Fix advertising the IFCAP_LINKSTATE capability.

zlei added a commit: rGcdd97f3aacf1: qlnxe: Fix advertising the IFCAP_LINKSTATE capability.Jul 31 2025, 4:41 AM

zlei added a commit: rGad08006c7fd5: qlnxe: Fix advertising the IFCAP_LINKSTATE capability.Oct 4 2025, 4:46 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

qlnx/

qlnxe/

4 lines

Diff 158880

sys/dev/qlnx/qlnxe/qlnx_os.c

Loading...