Differential D51216

cam: Add xpt_gdev_type() and use it instead of many copies of same
ClosedPublic
Actions

Authored by imp on Jul 8 2025, 10:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 30, 5:26 PM

	Unknown Object (File)
	Tue, Jul 28, 4:18 PM

	Unknown Object (File)
	Tue, Jul 28, 1:26 PM

	Unknown Object (File)
	Tue, Jul 7, 4:03 PM

	Unknown Object (File)
	Mon, Jul 6, 1:12 AM

	Unknown Object (File)
	Jul 5 2026, 6:33 AM

	Unknown Object (File)
	Jul 3 2026, 8:31 AM

	Unknown Object (File)
	Jul 3 2026, 4:29 AM

View All 64 Files

Subscribers

None

Details

Reviewers

mav
ken
jhb

Group Reviewers

Commits

rG5a656ef632de: cam: Add xpt_gdev_type() and use it instead of many copies of same

Summary

Add a convenience wrapper to XPT_GDEV_TYPE in the same way we have one
for XPT_PATH_INQ. The changes from PRIORITY_NORMAL to PRIORITY_NONE are
intentional because this isn't a queued CCB. Please note: we have
several places still that construct a XPT_GDEV_TYPE message by
overwriting a CCB that happens to be laying around. I've not used this
method, by and large, in those places since I didn't want to risk
upsetting allocation flags that might be present (since we use a specail
allocator for some CCB types in *_da.c).

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65287
Build 62170: arc lint + arc unit

Event Timeline

imp created this revision.Jul 8 2025, 10:52 PM

Herald added a reviewer: cam. · View Herald TranscriptJul 8 2025, 10:52 PM

imp requested review of this revision.Jul 8 2025, 10:52 PM

Harbormaster completed remote builds in B65287: Diff 158192.Jul 8 2025, 10:52 PM

imp added a parent revision: D51215: cam: Use less stack space.Jul 8 2025, 10:52 PM

s/specail/special/ in commit log

sys/cam/cam_xpt.h
168	New functions shouldn't have the leading blank line I think.

This revision is now accepted and ready to land.Jul 10 2025, 7:51 PM

imp added inline comments.Jul 10 2025, 10:55 PM

sys/cam/cam_xpt.h
168	I'll followup removing this and the function I copied it from. Good eye.

Closed by commit rG5a656ef632de: cam: Add xpt_gdev_type() and use it instead of many copies of same (authored by imp). · Explain WhyJul 23 2025, 1:09 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG5a656ef632de: cam: Add xpt_gdev_type() and use it instead of many copies of same.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ata/

5 lines

16 lines

18 lines

5 lines

mmc/

5 lines

scsi/

12 lines

8 lines

6 lines

6 lines

5 lines

7 lines

Diff 158192

sys/cam/ata/ata_da.c

Loading...

sys/cam/cam_periph.c

Loading...

sys/cam/cam_xpt.h

Loading...

sys/cam/cam_xpt.c

Loading...

sys/cam/mmc/mmc_da.c

Loading...

sys/cam/scsi/scsi_all.c

Loading...

sys/cam/scsi/scsi_cd.c

Loading...

sys/cam/scsi/scsi_ch.c

Loading...

sys/cam/scsi/scsi_da.c

Loading...

sys/cam/scsi/scsi_enc_ses.c

Loading...

sys/cam/scsi/scsi_sa.c

Loading...