Details
- Reviewers
bnovkov ziaee - Commits
- rGbc2e3360107a: hwt(4): Add initial man page.
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
I've been so excited for this! Awesome! Here's what I could find so far:
| share/man/man4/hwt.4 | ||
|---|---|---|
| 2 | You can use the SPDX short form as shown in style.9 or https://docs.freebsd.org/en/articles/license-guide/ | |
| 30 | This shouldn't be quoted | |
| 32–59 | AIUC? | |
| 63 | So, hwt is a framework, and coresight or pt are the drivers? | |
| 64 | Roff wants each sentence on it's own line | |
| 77 | ||
| 87 | ||
| 88 | Macros in argument width is an undefined behavior that misbehaves | |
| 90 | ||
| 92–93 | ||
| 99 | ||
| 101 | ||
| 109 | ||
| 127 | For maintainability | |
| 128–144 | Ioctls are usually Dv's afaict. I should probably put that in style.mdoc(5). | |
| 130 | ||
| 145–146 | ||
| share/man/man4/hwt.4 | ||
|---|---|---|
| 32–59 | You don't like this? | |
| share/man/man4/hwt.4 | ||
|---|---|---|
| 32–59 | Okay, thanks. "AIUC" is "am I understanding correctly". Can we describe it in DESCRIPTION? I'm trying to increase the consistency and predictability of the manual. I gave a 5 min lightning talk about it at BSDCan. https://people.freebsd.org/~ziaee/tmp/bsdcan25lightning-ziaee.webm | |
| share/man/man4/hwt.4 | ||
|---|---|---|
| 32–59 | Can you point to a similar man page as an example ? | |
https://man-dev.freebsd.org/vt
And in current (not synced to web interface yet), check out uftdi, uchcom, or pf
Just this one stupid nit, thank you.
I wonder if we should MLINKS this page to the drivers, spe/coresight/pt?
| share/man/man4/hwt.4 | ||
|---|---|---|
| 2 | ||