Differential D51150

Jail sysctls: deprecated a generic sysctl in favour of allow-flags
ClosedPublic
Actions

Authored by netchild on Jul 3 2025, 3:44 PM.

Details

Reviewers

None

Group Reviewers

Jails

Commits

rG6087050ef52c: Jail sysctls: deprecate generic sysctls in favour of allow-flags

Summary

add the missing sysctl to the deprecated list
add a comment to not add new generic sysctls and point to SYSCTL_JAIL_PARAM instead

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

netchild created this revision.Jul 3 2025, 3:44 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 3 2025, 3:44 PM

netchild requested review of this revision.Jul 3 2025, 3:44 PM

Yes, anything that makes these things more obviously deprecated is better.

Is this waiting on anything before commit?

Yes, it waits for me to remember that this is not committed...

I was wrong. It is committed. It just needs to be closed here. I do not see a way to close. Maybe I'm blind... the only thing I found was abandoning this revision.

I don't see it committed?

9fd978680db649 (Baptiste Daroussin      2024-01-04 15:09:44 +0100 5015) SYSCTL_PROC(_security_jail, OID_AUTO, mlock_allowed,
9fd978680db649 (Baptiste Daroussin      2024-01-04 15:09:44 +0100 5016)     CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE,
9fd978680db649 (Baptiste Daroussin      2024-01-04 15:09:44 +0100 5017)     NULL, PR_ALLOW_MLOCK, sysctl_jail_default_allow, "I",
9fd978680db649 (Baptiste Daroussin      2024-01-04 15:09:44 +0100 5018)     "Processes in jail can lock/unlock physical pages in memory");

Very strange. First "patch" told me it is already applied (it was a pristine src tree). Now I do a git diff and it is showing up. Pffft.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Mar 31, 5:24 PM

Closed by commit rG6087050ef52c: Jail sysctls: deprecate generic sysctls in favour of allow-flags (authored by netchild). · Explain Why

This revision was automatically updated to reflect the committed changes.

netchild added a commit: rG6087050ef52c: Jail sysctls: deprecate generic sysctls in favour of allow-flags.

Herald added a subscriber: olce. · View Herald TranscriptTue, Mar 31, 5:24 PM

Revision Contents
Changeset List

Path

Size

		kern/
	sys/	kern/

kern_jail.c

6 lines

Diff 157890

View Options

Jail sysctls: deprecated a generic sysctl in favour of allow-flagsClosedPublicActions