Page MenuHomeFreeBSD
Differential D51107

ichiic: Add PCI id for Arrow Lake.
ClosedPublic
Actions

Authored by takawata on Jul 1 2025, 2:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 1:42 PM
Unknown Object (File)
Fri, Oct 3, 10:36 AM
Unknown Object (File)
Thu, Oct 2, 6:03 PM
Unknown Object (File)
Wed, Oct 1, 1:36 PM
Unknown Object (File)
Tue, Sep 30, 9:20 AM
Unknown Object (File)
Mon, Sep 15, 2:18 AM
Unknown Object (File)
Sat, Sep 13, 11:43 PM
Unknown Object (File)
Sat, Sep 13, 9:18 PM
View All 32 Files
Subscribers
imp

Details

Reviewers
wulf
mav
Commits
rG879944679668: ichiic: Add PCI id for Arrow Lake.
Summary

Add PCI id for Arrow Lake to attach iic driver

Test Plan

load ig4iic driver on ThinkPad X13 Gen 6 and see iichid is works properly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 65176
Build 62059: arc lint + arc unit

Event Timeline

takawata created this revision.Jul 1 2025, 2:02 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 1 2025, 2:02 PM
takawata requested review of this revision.Jul 1 2025, 2:02 PM
Harbormaster completed remote builds in B65150: Diff 157787.Jul 1 2025, 2:02 PM
takawata added reviewers: wulf, mav.Jul 1 2025, 2:06 PM
mav accepted this revision.Jul 1 2025, 2:35 PM

I haven't tracked new things there, only hope that the IDs are right. But I just wonder about naming uniformity: previously we've already had "_H_" in constant names, while we never had "_U_".

This revision is now accepted and ready to land.Jul 1 2025, 2:35 PM
wulf added a comment.Jul 1 2025, 6:44 PM

There are more ArrowLake I2C device ids: 7750 and 7751. At least in share/misc/pci_vendors

takawata added a comment.Jul 2 2025, 5:32 AM
In D51107#1166682, @wulf wrote:

There are more ArrowLake I2C device ids: 7750 and 7751. At least in share/misc/pci_vendors

According to the Datasheet, I2C#4(7750),I2C#5(7751) only supports PIO mode, and I'm not sure the PIO mode only device will work or not.

https://edc.intel.com/content/www/us/en/design/products-and-solutions/processors-and-chipsets/core-ultra-200h-and-200u-series-processors-datasheet-volume-1-of-2/intel-serial-i-o-inter-integrated-circuit-i2c-controllers/

wulf added a comment.Jul 2 2025, 8:33 AM
In D51107#1166799, @takawata wrote:
In D51107#1166682, @wulf wrote:

There are more ArrowLake I2C device ids: 7750 and 7751. At least in share/misc/pci_vendors

According to the Datasheet, I2C#4(7750),I2C#5(7751) only supports PIO mode, and I'm not sure the PIO mode only device will work or not.

https://edc.intel.com/content/www/us/en/design/products-and-solutions/processors-and-chipsets/core-ultra-200h-and-200u-series-processors-datasheet-volume-1-of-2/intel-serial-i-o-inter-integrated-circuit-i2c-controllers/

MMIO(PIO?) is the only mode supported by ig4. DMA mode is not supported yet.

takawata updated this revision to Diff 157832.Jul 2 2025, 1:20 PM

Add i2c#4 i2c#5 IDs.

This revision now requires review to proceed.Jul 2 2025, 1:20 PM
Harbormaster completed remote builds in B65176: Diff 157832.Jul 2 2025, 1:20 PM
wulf accepted this revision.Jul 6 2025, 10:30 AM
This revision is now accepted and ready to land.Jul 6 2025, 10:30 AM
Closed by commit rG879944679668: ichiic: Add PCI id for Arrow Lake. (authored by takawata). · Explain WhyJul 8 2025, 2:22 PM
This revision was automatically updated to reflect the committed changes.
takawata added a commit: rG879944679668: ichiic: Add PCI id for Arrow Lake..

Revision Contents
Changeset List

PathSize
sys/
dev/
ichiic/
12 lines

Diff 157832

View Options

sys/dev/ichiic/ig4_pci.c

Loading...