Page MenuHomeFreeBSD

diff: Detect loops when diffing directories.
ClosedPublic

Authored by des on Jun 19 2025, 12:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 7, 9:10 AM
Unknown Object (File)
Mon, Jul 7, 8:48 AM
Unknown Object (File)
Mon, Jul 7, 5:13 AM
Unknown Object (File)
Mon, Jul 7, 2:12 AM
Unknown Object (File)
Sun, Jul 6, 10:48 AM
Unknown Object (File)
Fri, Jul 4, 8:51 PM
Unknown Object (File)
Wed, Jul 2, 9:11 PM
Unknown Object (File)
Mon, Jun 30, 10:47 PM
Subscribers

Details

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jun 19 2025, 12:48 PM
markj added a subscriber: markj.
markj added inline comments.
usr.bin/diff/diffdir.c
52
171
This revision is now accepted and ready to land.Jun 19 2025, 1:33 PM
des marked an inline comment as done.Jun 19 2025, 3:17 PM
des added inline comments.
usr.bin/diff/diffdir.c
52

If these were function variables I'd agree, but is that really needed for static heads? The initializer evaluates to { NULL }.

usr.bin/diff/diffdir.c
52

Today, it's not needed; tomorrow, who knows? The RB_* macros have been extensively reworked at least once in my memory, so I'd be conservative and include the initializers.

This revision now requires review to proceed.Jun 19 2025, 4:11 PM
des marked 2 inline comments as done.Jun 19 2025, 4:15 PM
This revision is now accepted and ready to land.Jun 19 2025, 4:16 PM
This revision was automatically updated to reflect the committed changes.