Paths

Table of Contentst

Differential D50936

diff: Detect loops when diffing directories.
ClosedPublic
Actions

Authored by des on Jun 19 2025, 12:48 PM.

Tags

None

Referenced Files

	F124362534: D50936.diff
	Fri, Jul 25, 5:02 PM

	Unknown Object (File)
	Mon, Jul 7, 9:10 AM

	Unknown Object (File)
	Mon, Jul 7, 8:48 AM

	Unknown Object (File)
	Mon, Jul 7, 5:13 AM

	Unknown Object (File)
	Mon, Jul 7, 2:12 AM

	Unknown Object (File)
	Sun, Jul 6, 10:48 AM

	Unknown Object (File)
	Fri, Jul 4, 8:51 PM

	Unknown Object (File)
	Wed, Jul 2, 9:11 PM

View All 16 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG42092e1b6625: diff: Detect loops when diffing directories.

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Jun 19 2025, 12:48 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2025, 12:48 PM

des requested review of this revision.Jun 19 2025, 12:48 PM

Harbormaster completed remote builds in B64979: Diff 157305.Jun 19 2025, 12:48 PM

des added a parent revision: D50935: libc: Add fscandir(), fscandir_b(), scandirat_b()..Jun 19 2025, 12:48 PM

markj accepted this revision as: markj.Jun 19 2025, 1:33 PM

markj added a subscriber: markj.

markj added inline comments.

usr.bin/diff/diffdir.c
52
171

This revision is now accepted and ready to land.Jun 19 2025, 1:33 PM

des marked an inline comment as done.Jun 19 2025, 3:17 PM

des added inline comments.

usr.bin/diff/diffdir.c
52	If these were function variables I'd agree, but is that really needed for static heads? The initializer evaluates to `{ NULL }`.

markj added inline comments.Jun 19 2025, 3:21 PM

usr.bin/diff/diffdir.c
52	Today, it's not needed; tomorrow, who knows? The RB_* macros have been extensively reworked at least once in my memory, so I'd be conservative and include the initializers.

review feedback

This revision now requires review to proceed.Jun 19 2025, 4:11 PM

Harbormaster completed remote builds in B64987: Diff 157320.Jun 19 2025, 4:11 PM

des marked 2 inline comments as done.Jun 19 2025, 4:15 PM

markj accepted this revision as: markj.Jun 19 2025, 4:16 PM

This revision is now accepted and ready to land.Jun 19 2025, 4:16 PM

Closed by commit rG42092e1b6625: diff: Detect loops when diffing directories. (authored by des). · Explain WhyJun 20 2025, 11:12 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG42092e1b6625: diff: Detect loops when diffing directories..

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

85 lines

tests/

17 lines

Diff 157349

usr.bin/diff/diffdir.c

Loading...

usr.bin/diff/tests/diff_test.sh

Loading...