Page MenuHomeFreeBSD
Differential D50936

diff: Detect loops when diffing directories.
ClosedPublic
Actions

Authored by des on Jun 19 2025, 12:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 15, 8:45 AM
Unknown Object (File)
Oct 26 2025, 8:08 PM
Unknown Object (File)
Oct 26 2025, 8:08 PM
Unknown Object (File)
Oct 26 2025, 8:08 PM
Unknown Object (File)
Oct 26 2025, 8:08 PM
Unknown Object (File)
Oct 26 2025, 2:24 PM
Unknown Object (File)
Oct 26 2025, 8:59 AM
Unknown Object (File)
Oct 25 2025, 3:14 PM
View All 47 Files
Subscribers
imp
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG42092e1b6625: diff: Detect loops when diffing directories.
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64987
Build 61870: arc lint + arc unit

Event Timeline

des created this revision.Jun 19 2025, 12:48 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 19 2025, 12:48 PM
des requested review of this revision.Jun 19 2025, 12:48 PM
Harbormaster completed remote builds in B64979: Diff 157305.Jun 19 2025, 12:48 PM
des added a parent revision: D50935: libc: Add fscandir(), fscandir_b(), scandirat_b()..Jun 19 2025, 12:48 PM
markj accepted this revision as: markj.Jun 19 2025, 1:33 PM
markj added a subscriber: markj.
markj added inline comments.
usr.bin/diff/diffdir.c
52
171
This revision is now accepted and ready to land.Jun 19 2025, 1:33 PM
des marked an inline comment as done.Jun 19 2025, 3:17 PM
des added inline comments.
usr.bin/diff/diffdir.c
52

If these were function variables I'd agree, but is that really needed for static heads? The initializer evaluates to { NULL }.

markj added inline comments.Jun 19 2025, 3:21 PM
usr.bin/diff/diffdir.c
52

Today, it's not needed; tomorrow, who knows? The RB_* macros have been extensively reworked at least once in my memory, so I'd be conservative and include the initializers.

des updated this revision to Diff 157320.Jun 19 2025, 4:11 PM

review feedback

This revision now requires review to proceed.Jun 19 2025, 4:11 PM
Harbormaster completed remote builds in B64987: Diff 157320.Jun 19 2025, 4:11 PM
des marked 2 inline comments as done.Jun 19 2025, 4:15 PM
markj accepted this revision as: markj.Jun 19 2025, 4:16 PM
This revision is now accepted and ready to land.Jun 19 2025, 4:16 PM
Closed by commit rG42092e1b6625: diff: Detect loops when diffing directories. (authored by des). · Explain WhyJun 20 2025, 11:12 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG42092e1b6625: diff: Detect loops when diffing directories..

Revision Contents
Changeset List

PathSize
usr.bin/
diff/
85 lines
tests/
17 lines

Diff 157320

View Options

usr.bin/diff/diffdir.c

Loading...
View Options

usr.bin/diff/tests/diff_test.sh

Loading...