Page MenuHomeFreeBSD

Mk/Scripts/qa.sh: Fix false positives in LIB_DEPENDS warnings
ClosedPublic

Authored by jrm on Jun 14 2025, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 10, 1:40 AM
Unknown Object (File)
Sun, Nov 9, 1:35 AM
Unknown Object (File)
Tue, Oct 28, 5:22 AM
Unknown Object (File)
Wed, Oct 22, 7:21 PM
Unknown Object (File)
Tue, Oct 21, 12:55 PM
Unknown Object (File)
Sun, Oct 19, 2:00 AM
Unknown Object (File)
Sat, Oct 18, 11:17 PM
Unknown Object (File)
Sat, Oct 18, 8:24 PM
Subscribers

Details

Summary

To warn when library dependencies may not be required, the proxydeps()
function compares the libraries listed in LIB_DEPENDS with those
reported by ldd. However, the list from ldd is sanitized to remove
version information from the library names, while the entries from
LIB_DEPENDS are not. This leads to comparisons such as libreadline.so.8
from LIB_DEPENDS versus libreadline.so from ldd, resulting in false
positives. Adjust the comparison to avoid such false-positive warnings.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64923
Build 61806: arc lint + arc unit

Event Timeline

jrm requested review of this revision.Jun 14 2025, 9:39 PM
jrm created this revision.
emaste added inline comments.
Mk/Scripts/qa.sh
726
726

or ${library%%.so*}.so where used in the line below

This revision is now accepted and ready to land.Jun 16 2025, 11:22 PM

Incorporate changes from emaste and rene

This revision now requires review to proceed.Jun 16 2025, 11:23 PM
This revision is now accepted and ready to land.Jun 16 2025, 11:24 PM