Page MenuHomeFreeBSD

Mk/Scripts/qa.sh: Fix false positives in LIB_DEPENDS warnings
ClosedPublic

Authored by jrm on Jun 14 2025, 9:39 PM.
Tags
None
Referenced Files
F125029955: D50860.id157051.diff
Sat, Aug 2, 3:07 PM
Unknown Object (File)
Wed, Jul 30, 9:50 AM
Unknown Object (File)
Tue, Jul 29, 9:17 AM
Unknown Object (File)
Tue, Jul 29, 7:48 AM
Unknown Object (File)
Tue, Jul 29, 6:34 AM
Unknown Object (File)
Tue, Jul 29, 4:13 AM
Unknown Object (File)
Tue, Jul 29, 1:47 AM
Unknown Object (File)
Sun, Jul 27, 6:29 AM
Subscribers

Details

Summary

To warn when library dependencies may not be required, the proxydeps()
function compares the libraries listed in LIB_DEPENDS with those
reported by ldd. However, the list from ldd is sanitized to remove
version information from the library names, while the entries from
LIB_DEPENDS are not. This leads to comparisons such as libreadline.so.8
from LIB_DEPENDS versus libreadline.so from ldd, resulting in false
positives. Adjust the comparison to avoid such false-positive warnings.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm requested review of this revision.Jun 14 2025, 9:39 PM
jrm created this revision.
emaste added inline comments.
Mk/Scripts/qa.sh
726
726

or ${library%%.so*}.so where used in the line below

This revision is now accepted and ready to land.Jun 16 2025, 11:22 PM

Incorporate changes from emaste and rene

This revision now requires review to proceed.Jun 16 2025, 11:23 PM
This revision is now accepted and ready to land.Jun 16 2025, 11:24 PM