Page MenuHomeFreeBSD

Mk/Scripts/qa.sh: Fix false positives in LIB_DEPENDS warnings
ClosedPublic

Authored by jrm on Sat, Jun 14, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 29, 4:12 PM
Unknown Object (File)
Fri, Jun 27, 11:18 AM
Unknown Object (File)
Thu, Jun 26, 7:56 PM
Unknown Object (File)
Thu, Jun 26, 1:49 AM
Unknown Object (File)
Tue, Jun 24, 5:43 PM
Unknown Object (File)
Tue, Jun 24, 5:26 PM
Unknown Object (File)
Fri, Jun 20, 4:23 PM
Unknown Object (File)
Fri, Jun 20, 3:05 PM
Subscribers

Details

Summary

To warn when library dependencies may not be required, the proxydeps()
function compares the libraries listed in LIB_DEPENDS with those
reported by ldd. However, the list from ldd is sanitized to remove
version information from the library names, while the entries from
LIB_DEPENDS are not. This leads to comparisons such as libreadline.so.8
from LIB_DEPENDS versus libreadline.so from ldd, resulting in false
positives. Adjust the comparison to avoid such false-positive warnings.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64880
Build 61763: arc lint + arc unit

Event Timeline

jrm requested review of this revision.Sat, Jun 14, 9:39 PM
jrm created this revision.
emaste added inline comments.
Mk/Scripts/qa.sh
726
726

or ${library%%.so*}.so where used in the line below

This revision is now accepted and ready to land.Mon, Jun 16, 11:22 PM

Incorporate changes from emaste and rene

This revision now requires review to proceed.Mon, Jun 16, 11:23 PM
This revision is now accepted and ready to land.Mon, Jun 16, 11:24 PM