Differential D50792

vm/vm_mmap.c: provide extended errors for most places
ClosedPublic
Actions

Authored by kib on Wed, Jun 11, 8:39 AM.

Tags

None

Referenced Files

	F122428330: D50792.diff
	Sat, Jul 5, 7:02 AM

	F122394058: D50792.id156940.diff
	Fri, Jul 4, 11:21 PM

	Unknown Object (File)
	Fri, Jul 4, 8:42 PM

	Unknown Object (File)
	Fri, Jul 4, 11:00 AM

	Unknown Object (File)
	Fri, Jul 4, 1:49 AM

	Unknown Object (File)
	Thu, Jul 3, 6:40 PM

	Unknown Object (File)
	Thu, Jul 3, 12:33 PM

	Unknown Object (File)
	Tue, Jul 1, 5:55 PM

View All 29 Files

Subscribers

Details

Reviewers

brooks
emaste

Commits

rGf1ad4340e4ad: vm/vm_mmap.c: provide extended errors for most places

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Wed, Jun 11, 8:39 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jun 11, 8:39 AM

kib requested review of this revision.Wed, Jun 11, 8:39 AM

brooks accepted this revision.Thu, Jun 12, 8:25 PM

brooks added inline comments.

sys/vm/vm_mmap.c
1704	Is the intent here that this is a backup message if the caller doesn't provide a more specific one? I might use "mach vm error" for the message.

This revision is now accepted and ready to land.Thu, Jun 12, 8:25 PM

kib added inline comments.Thu, Jun 12, 8:31 PM

sys/vm/vm_mmap.c
1704	Mach errors are not in errno namespace, so I do not think it is appropriate to use SET_ERROR() in the vm_map.c or vm_object.c code, which is called into by vm_mmap.c to do the actual work. Generally SET_ERROR() should be only used in the place where the error is detected, but for Mach code it is not right.

Closed by commit rGf1ad4340e4ad: vm/vm_mmap.c: provide extended errors for most places (authored by kib). · Explain WhyThu, Jun 12, 8:55 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGf1ad4340e4ad: vm/vm_mmap.c: provide extended errors for most places.

Revision Contents
Changeset List

Path

Size

sys/

vm/

103 lines

Diff 156940

sys/vm/vm_mmap.c

Loading...