security/krb5-12{0,1}: Consolidate KRB5_{PDF,HTML} options into canonical DOCS option
ClosedPublic
Actions

Authored by michaelo on Jun 10 2025, 10:21 AM.

Details

Reviewers

jrm
otis
cy

Commits

R11:40efd24799a5: security/krb5-12{0,1}: Consolidate KRB5_{PDF,HTML} options into canonical DOCS…

Summary

Let users globally decide whether they want to have these docs in their
ports.

PR: 287340
Approved by: jrm (mentor), otis (mentor), cy (maintainer)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64741
Build 61625: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Jun 10 2025, 10:21 AM

michaelo created this revision.

Harbormaster completed remote builds in B64741: Diff 156777.Jun 10 2025, 10:21 AM

michaelo retitled this revision from security/krb5-12{0,1}: Consolidate KRB_{PDF,HTML} options into canonical DOCS option to security/krb5-12{0,1}: Consolidate KRB5_{PDF,HTML} options into canonical DOCS option.Jun 10 2025, 11:06 AM

Add note in UPDATING

Harbormaster completed remote builds in B64742: Diff 156779.Jun 10 2025, 11:08 AM

LGTM

This revision is now accepted and ready to land.Jun 10 2025, 12:52 PM

You can also add approved by maintainer to your commit log message.

In D50775#1158796, @cy wrote:

You can also add approved by maintainer to your commit log message.

This I have, though I am not sure whether I need mentor approval as well along with maintainer approval.

@otis , formally OK for you?

otis accepted this revision.Jun 10 2025, 1:17 PM

Closed by commit R11:40efd24799a5: security/krb5-12{0,1}: Consolidate KRB5_{PDF,HTML} options into canonical DOCS… (authored by michaelo). · Explain WhyJun 10 2025, 1:23 PM

This revision was automatically updated to reflect the committed changes.

michaelo added a commit: R11:40efd24799a5: security/krb5-12{0,1}: Consolidate KRB5_{PDF,HTML} options into canonical DOCS….

In D50775#1158797, @michaelo wrote:

In D50775#1158796, @cy wrote:

You can also add approved by maintainer to your commit log message.

This I have, though I am not sure whether I need mentor approval as well along with maintainer approval.

Yes, you also need mentor approval.

In D50775#1158833, @cy wrote:

In D50775#1158797, @michaelo wrote:

In D50775#1158796, @cy wrote:

You can also add approved by maintainer to your commit log message.

This I have, though I am not sure whether I need mentor approval as well along with maintainer approval.

Yes, you also need mentor approval.