Differential D50594

rtld-elf: Pass TCB to allocate_module_tls to avoid re-getting
ClosedPublic
Actions

Authored by jrtc27 on Wed, May 28, 11:03 PM.

Tags

None

Referenced Files

	F119244375: D50594.id.diff
	Fri, Jun 6, 7:25 PM

	Unknown Object (File)
	Thu, Jun 5, 9:39 AM

	Unknown Object (File)
	Sun, Jun 1, 6:00 PM

	Unknown Object (File)
	Thu, May 29, 4:43 PM

Subscribers

Details

Reviewers

Commits

rG48fd084579af: rtld-elf: Pass TCB to allocate_module_tls to avoid re-getting

Summary

The only caller already has the current TCB to hand, so just pass it
down rather than get it again. This also makes it clear in the caller
that it depends on the (current) TCB, rather than being storage that
could be assigned to any thread (concurrency issues aside).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64525
Build 61409: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Wed, May 28, 11:03 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptWed, May 28, 11:03 PM

jrtc27 requested review of this revision.Wed, May 28, 11:03 PM

Harbormaster completed remote builds in B64525: Diff 156242.Wed, May 28, 11:03 PM

jrtc27 added a parent revision: D50591: rtld-elf: Pass struct tcb * around rather than struct dtv **.Wed, May 28, 11:03 PM

kib accepted this revision.Wed, May 28, 11:59 PM

This revision is now accepted and ready to land.Wed, May 28, 11:59 PM

Closed by commit rG48fd084579af: rtld-elf: Pass TCB to allocate_module_tls to avoid re-getting (authored by jrtc27). · Explain WhyThu, May 29, 4:08 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG48fd084579af: rtld-elf: Pass TCB to allocate_module_tls to avoid re-getting.

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

2 lines

8 lines

Diff 156242

libexec/rtld-elf/rtld.h

Loading...

libexec/rtld-elf/rtld.c

Loading...