Page MenuHomeFreeBSD
Differential D50342

release: fix pkg METALOG in Makefile
AbandonedPublic
Actions

Authored by ifreund_freebsdfoundation.org on May 14 2025, 7:42 AM.
Tags
None
Referenced Files
F163192761: D50342.diff
Mon, Jul 20, 10:28 PM
Unknown Object (File)
Thu, Jul 9, 6:11 AM
Unknown Object (File)
Tue, Jul 7, 7:04 PM
Unknown Object (File)
May 28 2026, 11:15 AM
Unknown Object (File)
May 27 2026, 12:41 AM
Unknown Object (File)
May 25 2026, 11:04 AM
Unknown Object (File)
May 11 2026, 3:25 AM
Unknown Object (File)
May 3 2026, 4:55 AM
View All 44 Files
Subscribers
imp
jrtc27
patmaddox

Details

Reviewers
emaste
Group Reviewers
releng
Summary

From my testing, none of the PKG_INSTALL invocations in release/Makefile
actually work currently due to pkg writing to the wrong METALOG file.

Since PKG_ARGS refers to the METALOG in the working directory, we must
be careful to run pkg from the directory containing the correct METALOG.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64156
Build 61040: arc lint + arc unit

Event Timeline

ifreund_freebsdfoundation.org created this revision.May 14 2025, 7:42 AM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptMay 14 2025, 7:42 AM
ifreund_freebsdfoundation.org requested review of this revision.May 14 2025, 7:42 AM
ifreund_freebsdfoundation.org added a reviewer: releng.May 14 2025, 7:43 AM
Harbormaster completed remote builds in B64156: Diff 155425.May 14 2025, 7:43 AM
ifreund_freebsdfoundation.org added a comment.May 14 2025, 8:51 AM

Uh I'm not sure how I messed up my testing but this patch is incorrect, everything works fine since pkg interprets the METALOG option relative to the rootdir option.

Sorry for the noise.

ifreund_freebsdfoundation.org abandoned this revision.May 14 2025, 8:51 AM
ifreund_freebsdfoundation.org added a comment.May 14 2025, 10:09 AM

Aha! The thing I was seeing happened again and I think I understand it now, submitted D50344.

patmaddox added a subscriber: patmaddox.May 20 2025, 6:43 PM

Revision Contents
Changeset List

PathSize
release/
19 lines

Diff 155425

View Options

release/Makefile

Loading...