openpam: Provide escape route for missing modules.
AbandonedPublic
Actions

Authored by des on May 7 2025, 3:51 PM.

Details

Reviewers

Summary

If the type field is prefixed with a hyphen, and the module is not
found on disk, ignore the entry instead of failing. This simplifies
management of systems which rely on third-party PAM modules.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63996
Build 60880: arc lint + arc unit

Event Timeline

des created this revision.May 7 2025, 3:51 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 7 2025, 3:51 PM

des requested review of this revision.May 7 2025, 3:51 PM

Harbormaster completed remote builds in B63996: Diff 155064.May 7 2025, 3:51 PM

to make it easier to review this change, could you please describe what the current behaviour is, and what the behaviour would be with your change?

you might also consider providing a test case for this change.

contrib/openpam/lib/libpam/openpam_configure.c
296

In D50240#1145814, @ivy wrote:

to make it easier to review this change, could you please describe what the current behaviour is, and what the behaviour would be with your change?

The current behavior is described in pam.conf(5). The change is described in the commit message.

contrib/openpam/lib/libpam/openpam_configure.c
296	no, this is third-party code which follows its own style.

des marked an inline comment as done.May 7 2025, 5:50 PM

arrowd added a subscriber: arrowd.May 10 2025, 9:57 AM

des abandoned this revision.May 23 2025, 8:48 PM

Why was this abandoned?

It was committed upstream and imported in rG45538173c120.

Revision Contents
Changeset List

Path

Size

contrib/

openpam/

lib/

libpam/

openpam_configure.c

84 lines

Diff 155064

View Options

contrib/openpam/lib/libpam/openpam_configure.c

openpam: Provide escape route for missing modules.AbandonedPublicActions