Differential D50224

libc: Reassociate pointer arithmetic in __libc_tls_get_addr
ClosedPublic
Actions

Authored by jrtc27 on May 7 2025, 2:59 AM.

Tags

None

Referenced Files

	F171450307: D50224.id155076.diff
	Fri, Sep 11, 4:36 AM

	F171427327: D50224.id.diff
	Fri, Sep 11, 2:13 AM

	Unknown Object (File)
	Sat, Sep 5, 9:42 PM

	Unknown Object (File)
	Sat, Sep 5, 2:28 PM

	Unknown Object (File)
	Sat, Sep 5, 6:22 AM

	Unknown Object (File)
	Fri, Sep 4, 6:01 PM

	Unknown Object (File)
	Thu, Sep 3, 7:09 PM

	Unknown Object (File)
	Thu, Sep 3, 1:02 PM

Subscribers

Details

Reviewers

Commits

rG7953cbaabe7c: libc: Reassociate pointer arithmetic in __libc_tls_get_addr

Summary

Rather than compute a biased pointer only to then un-bias it again, un-bias
the offset before adding it to the DTV entry.

This mirrors rtld-elf commit d71c97026366 ("rtld-elf: Push
TLS_DTV_OFFSET into tls_get_addr_common's arguments")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 63975
Build 60859: arc lint + arc unit

Event Timeline

jrtc27 created this revision.May 7 2025, 2:59 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 7 2025, 2:59 AM

jrtc27 requested review of this revision.May 7 2025, 2:59 AM

Harbormaster completed remote builds in B63975: Diff 155021.May 7 2025, 2:59 AM

jrtc27 added a child revision: D50225: libc: Consistently use uintptr_t for TLS implementation.May 7 2025, 3:08 AM

kib accepted this revision.May 7 2025, 4:29 PM

This revision is now accepted and ready to land.May 7 2025, 4:29 PM

Closed by commit rG7953cbaabe7c: libc: Reassociate pointer arithmetic in __libc_tls_get_addr (authored by jrtc27). · Explain WhyMay 7 2025, 7:22 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG7953cbaabe7c: libc: Reassociate pointer arithmetic in __libc_tls_get_addr.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

4 lines

Diff 155021

lib/libc/gen/tls.c

Loading...