makefs: Use gmtime() instead of localtime for timestamps
ClosedPublic
Actions

Authored by markj on May 6 2025, 3:59 PM.

Details

Reviewers

Commits

rG4b3ee88ea7f8: makefs: Use gmtime() instead of localtime for timestamps
rG018493d32ac2: makefs: Use gmtime() instead of localtime for timestamps

Summary

Otherwise the output file's contents will depend on the configured time
zone.

Sponsored by: Klara, Inc.
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63948
Build 60832: arc lint + arc unit

Event Timeline

markj created this revision.May 6 2025, 3:59 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2025, 3:59 PM

markj requested review of this revision.May 6 2025, 3:59 PM

Harbormaster completed remote builds in B63948: Diff 154954.May 6 2025, 4:00 PM

I wonder if it would make sense to use gmtime_r unconditionally?

In D50198#1144986, @emaste wrote:

I wonder if it would make sense to use gmtime_r unconditionally?

That would probably be fine. There's no real reason to expect the resulting image to be mounted in the same time zone as the host where it was created...

Anyhow I'm fine either as is or with only gmtime_r.

This revision is now accepted and ready to land.May 6 2025, 4:49 PM

Closed by commit rG018493d32ac2: makefs: Use gmtime() instead of localtime for timestamps (authored by markj). · Explain WhyMay 8 2025, 4:04 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG018493d32ac2: makefs: Use gmtime() instead of localtime for timestamps.

markj added a commit: rG4b3ee88ea7f8: makefs: Use gmtime() instead of localtime for timestamps.Jun 20 2025, 1:52 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

makefs/

msdos/

msdosfs_vnops.c

5 lines

Diff 154954

View Options

usr.sbin/makefs/msdos/msdosfs_vnops.c

makefs: Use gmtime() instead of localtime for timestampsClosedPublicActions