Page MenuHomeFreeBSD
Differential D50198

makefs: Use gmtime() instead of localtime for timestamps
ClosedPublic
Actions

Authored by markj on May 6 2025, 3:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 3, 3:59 AM
Unknown Object (File)
Thu, Jun 26, 5:21 PM
Unknown Object (File)
Thu, Jun 26, 5:31 AM
Unknown Object (File)
Thu, Jun 26, 5:19 AM
Unknown Object (File)
Wed, Jun 25, 6:31 AM
Unknown Object (File)
Wed, Jun 25, 4:57 AM
Unknown Object (File)
Tue, Jun 24, 5:47 PM
Unknown Object (File)
Mon, Jun 23, 2:54 PM
View All 22 Files
Subscribers
imp

Details

Reviewers
emaste
Commits
rG4b3ee88ea7f8: makefs: Use gmtime() instead of localtime for timestamps
rG018493d32ac2: makefs: Use gmtime() instead of localtime for timestamps
Summary

Otherwise the output file's contents will depend on the configured time
zone.

Sponsored by: Klara, Inc.
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.May 6 2025, 3:59 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 6 2025, 3:59 PM
markj requested review of this revision.May 6 2025, 3:59 PM
Harbormaster completed remote builds in B63948: Diff 154954.May 6 2025, 4:00 PM
emaste added a comment.May 6 2025, 4:40 PM

I wonder if it would make sense to use gmtime_r unconditionally?

markj added a comment.May 6 2025, 4:42 PM
In D50198#1144986, @emaste wrote:

I wonder if it would make sense to use gmtime_r unconditionally?

That would probably be fine. There's no real reason to expect the resulting image to be mounted in the same time zone as the host where it was created...

emaste accepted this revision.May 6 2025, 4:49 PM

Anyhow I'm fine either as is or with only gmtime_r.

This revision is now accepted and ready to land.May 6 2025, 4:49 PM
Closed by commit rG018493d32ac2: makefs: Use gmtime() instead of localtime for timestamps (authored by markj). · Explain WhyMay 8 2025, 4:04 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG018493d32ac2: makefs: Use gmtime() instead of localtime for timestamps.
markj added a commit: rG4b3ee88ea7f8: makefs: Use gmtime() instead of localtime for timestamps.Fri, Jun 20, 1:52 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
makefs/
msdos/
2 lines

Diff 155138

View Options

usr.sbin/makefs/msdos/msdosfs_vnops.c

Loading...