Page MenuHomeFreeBSD
Differential D50157

LinuxKPI: add struct_group_tagged()
ClosedPublic
Actions

Authored by bz on May 4 2025, 10:15 PM.
Tags
None
Referenced Files
F166503416: D50157.id156163.diff
Thu, Aug 13, 8:51 PM
F166462675: D50157.diff
Thu, Aug 13, 5:33 PM
Unknown Object (File)
Wed, Aug 12, 9:15 PM
Unknown Object (File)
Wed, Aug 12, 2:22 PM
Unknown Object (File)
Tue, Aug 11, 5:41 PM
Unknown Object (File)
Mon, Aug 10, 2:18 PM
Unknown Object (File)
Mon, Aug 10, 12:59 PM
Unknown Object (File)
Mon, Aug 10, 9:52 AM
View All 99 Files
Subscribers
dumbbell
emaste

Details

Reviewers
imp
dumbbell
Group Reviewers
linuxkpi
Commits
rG6573b7db7143: LinuxKPI: add struct_group_tagged()
rG54d0e1772fb6: LinuxKPI: add struct_group_tagged()
Summary

Restructure struct_group() into a wrapper around __struct_group().
Various callers have arguments annotated as /* no foo */ so try to
add all we can find.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

I am not sure about the "public Domain" @emaste

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 63881
Build 60765: arc lint + arc unit

Event Timeline

bz requested review of this revision.May 4 2025, 10:15 PM
bz created this revision.
Harbormaster completed remote builds in B63881: Diff 154814.May 4 2025, 10:15 PM
bz added a parent revision: D50156: bnxt: add guards around struct_group macros.May 4 2025, 10:15 PM
emaste added a comment.May 5 2025, 4:10 PM

This file is close to trivial before and after this change so I wouldn't worry too much about having Public domain on it.

bz added a comment.May 5 2025, 6:16 PM
In D50157#1144353, @emaste wrote:

This file is close to trivial before and after this change so I wouldn't worry too much about having Public domain on it.

Ok, thanks!

bz added a comment.May 13 2025, 11:44 PM

Anyone for this one?

dumbbell accepted this revision.May 14 2025, 4:45 PM
dumbbell added a subscriber: dumbbell.

Looks good to me.

This revision is now accepted and ready to land.May 14 2025, 4:45 PM
Closed by commit rG54d0e1772fb6: LinuxKPI: add struct_group_tagged() (authored by bz). · Explain WhyMay 28 2025, 10:44 AM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG54d0e1772fb6: LinuxKPI: add struct_group_tagged().
bz added a commit: rG6573b7db7143: LinuxKPI: add struct_group_tagged().Jun 4 2025, 10:24 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
26 lines

Diff 154814

View Options

sys/compat/linuxkpi/common/include/linux/stddef.h

Loading...