kyua: Don't pass NULL to unique_ptr constructors
ClosedPublic
Actions

Authored by jhb on Apr 30 2025, 4:57 PM.

Details

Reviewers

olce
emaste

Commits

rG7982c36da11c: kyua: Don't pass NULL to unique_ptr constructors
rG26d4ac7a2725: kyua: Don't pass NULL to unique_ptr constructors

Summary

This is ambiguous when NULL is defined to an integral constant.
Instead, use the more iodiomatic pattern of {} to construct a default
pointer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 30 2025, 4:57 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 30 2025, 4:57 PM

jhb requested review of this revision.Apr 30 2025, 4:57 PM

jhb added a parent revision: D50089: Don't define NULL to nullptr in C++11 mode.

jhb added a child revision: D50091: kyua: Don't pass NULL to std::unique_ptr<>::reset().

Harbormaster completed remote builds in B63805: Diff 154556.Apr 30 2025, 4:57 PM

This fixes the build with GCC.

Also included in https://github.com/freebsd/kyua/pull/265

olce accepted this revision.May 1 2025, 9:13 AM

This revision is now accepted and ready to land.May 1 2025, 9:13 AM

Closed by commit rG26d4ac7a2725: kyua: Don't pass NULL to unique_ptr constructors (authored by jhb). · Explain WhyMay 3 2025, 3:59 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG26d4ac7a2725: kyua: Don't pass NULL to unique_ptr constructors.

jhb added a commit: rG7982c36da11c: kyua: Don't pass NULL to unique_ptr constructors.Thu, Jan 29, 3:40 PM

Revision Contents
Changeset List

Path

Size

contrib/

kyua/

utils/

process/

child.cpp

4 lines

Diff 154753

View Options

contrib/kyua/utils/process/child.cpp

kyua: Don't pass NULL to unique_ptr constructorsClosedPublicActions