kyua: Don't pass NULL to std::unique_ptr<>::reset()
ClosedPublic
Actions

Authored by jhb on Wed, Apr 30, 4:57 PM.

Details

Reviewers

olce
emaste

Commits

rGd61c8bca8648: kyua: Don't pass NULL to std::unique_ptr<>::reset()

Summary

No functional change, this is simply more idiomatic.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Wed, Apr 30, 4:57 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Apr 30, 4:57 PM

jhb requested review of this revision.Wed, Apr 30, 4:57 PM

jhb added a parent revision: D50090: kyua: Don't pass NULL to unique_ptr constructors.

Harbormaster completed remote builds in B63806: Diff 154557.Wed, Apr 30, 4:57 PM

Also included in https://github.com/freebsd/kyua/pull/265

emaste accepted this revision.Wed, Apr 30, 5:03 PM

This revision is now accepted and ready to land.Wed, Apr 30, 5:03 PM

olce accepted this revision.Thu, May 1, 9:11 AM

Closed by commit rGd61c8bca8648: kyua: Don't pass NULL to std::unique_ptr<>::reset() (authored by jhb). · Explain WhySat, May 3, 3:59 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGd61c8bca8648: kyua: Don't pass NULL to std::unique_ptr<>::reset().

Revision Contents
Changeset List

Path

Size

contrib/

kyua/

utils/

fs/

directory.cpp

2 lines

logging/

operations.cpp

2 lines

process/

child.cpp

10 lines

executor.cpp

4 lines

signals/

interrupts.cpp

6 lines

timer.cpp

6 lines

Diff 154752

View Options

contrib/kyua/utils/fs/directory.cpp

View Options

contrib/kyua/utils/logging/operations.cpp

View Options

contrib/kyua/utils/process/child.cpp

View Options

contrib/kyua/utils/process/executor.cpp

View Options

contrib/kyua/utils/signals/interrupts.cpp

View Options

contrib/kyua/utils/signals/timer.cpp

kyua: Don't pass NULL to std::unique_ptr<>::reset()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 154752

contrib/kyua/utils/fs/directory.cpp

contrib/kyua/utils/logging/operations.cpp

contrib/kyua/utils/process/child.cpp

contrib/kyua/utils/process/executor.cpp

contrib/kyua/utils/signals/interrupts.cpp

contrib/kyua/utils/signals/timer.cpp

kyua: Don't pass NULL to std::unique_ptr<>::reset()
ClosedPublic
Actions

Revision Contents
Changeset List