Make sure the memory region definitions are zeroed before use.
ClosedPublic
Actions

Authored by kp on Wed, Apr 30, 1:49 PM.

Details

Reviewers

andrew
mmel

Group Reviewers

pfsense

Commits

rG4e3a6fe0134e: Make sure the memory region definitions are zeroed before use.

Summary

Since only 32bits of the values are read from the fdt, the existing values
can compromise the results.

Fixes the boot on the Netgate 3100.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Wed, Apr 30, 1:49 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Apr 30, 1:49 PM

kp requested review of this revision.Wed, Apr 30, 1:49 PM

Harbormaster completed remote builds in B63799: Diff 154544.Wed, Apr 30, 1:49 PM

(Work by Luiz Souza <luiz@netgate.com>)

I thought @mmel found the issue. The issue is previously we would zero the stack & the array used was the first thing in the stack location so was zero, however this shouldn't have been relied on.

This revision is now accepted and ready to land.Wed, Apr 30, 2:40 PM

imho, using two temporary ulong variables for function calls and assigning them to mem_region members gives the compiler a chance to complain. But both versions are OK for me.
And my apology for not committed this fix in time...
Michal

See: https://github.com/strejda/tegra/commit/70eb56b778cd9c968f19b5f04be7b2e0032ca398

Closed by commit rG4e3a6fe0134e: Make sure the memory region definitions are zeroed before use. (authored by loos, committed by kp). · Explain WhyThu, May 1, 8:24 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG4e3a6fe0134e: Make sure the memory region definitions are zeroed before use..