Page MenuHomeFreeBSD
Differential D50086

misc/compat14x: Add port by extracting out of compat13x
ClosedPublic
Actions

Authored by arrowd on Apr 30 2025, 4:38 PM.
Tags
None
Referenced Files
F126575919: D50086.id154742.diff
Thu, Aug 21, 5:34 AM
F126530056: D50086.id154849.diff
Wed, Aug 20, 3:26 PM
Unknown Object (File)
Fri, Aug 15, 11:57 AM
Unknown Object (File)
Fri, Aug 15, 10:18 AM
Unknown Object (File)
Mon, Aug 11, 2:16 PM
Unknown Object (File)
Sun, Aug 10, 10:22 PM
Unknown Object (File)
Fri, Aug 8, 3:34 AM
Unknown Object (File)
Tue, Aug 5, 2:54 AM
View All 41 Files
Subscribers
des
emaste
markmi_dsl-only.net

Details

Reviewers
des
bapt
Commits
R11:517d30dd6bbf: misc/compat*x: Rephrase pkg-descr
R11:ccb90462377e: misc/compat13x: Stop installing libmd.so, it is now provided by compat14x
R11:28c3b8a7b9ef: misc/compat14x: Add the port by extracting it out of compat13x
Summary

Before pushing I wanted to make sure that I get it right. @des is this
what you suggested earlier?

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 63816
Build 60700: arc lint + arc unit

Event Timeline

arrowd created this revision.Apr 30 2025, 4:38 PM
Herald added a subscriber: emaste. · View Herald TranscriptApr 30 2025, 4:38 PM
arrowd requested review of this revision.Apr 30 2025, 4:38 PM
Harbormaster completed remote builds in B63802: Diff 154550.Apr 30 2025, 4:38 PM
des requested changes to this revision.Apr 30 2025, 5:15 PM
des added inline comments.
misc/compat13x/Makefile
29
misc/compat14x/pkg-descr
2
11
This revision now requires changes to proceed.Apr 30 2025, 5:15 PM
arrowd updated this revision to Diff 154607.May 1 2025, 7:47 AM
arrowd marked 2 inline comments as done.
  • Address comments
Harbormaster completed remote builds in B63816: Diff 154607.May 1 2025, 7:47 AM
arrowd added inline comments.May 1 2025, 7:49 AM
misc/compat13x/Makefile
29

I'm confused again. misc/compat12x has >= 1400000 in this place, why compat13x also has to have 14 there?

emaste added inline comments.May 1 2025, 12:32 PM
misc/compat13x/pkg-plist.aarch64
2

was libmd originally added instead of full compat14x for FreeBSD 15? Or is it needed by some earlier 14.x?

misc/compat14x/pkg-descr
1

I'd say this package provides the compat14x libraries -- to me "allows you to install" suggests that once you have compat14x installed you can then do something to install the libraries themselves.

arrowd updated this revision to Diff 154619.May 1 2025, 12:42 PM
arrowd marked an inline comment as done.
  • Address comment
Harbormaster completed remote builds in B63819: Diff 154619.May 1 2025, 12:42 PM
arrowd added inline comments.May 1 2025, 12:43 PM
misc/compat13x/pkg-plist.aarch64
2

I initially added libmd to compat13x because pkg was complaining about missing the required library. Then @des suggested moving it into a separate package, because libmd got bumped in 15, not 14.

I added @comments there to avoid rerolling distfiles for compat13x.

des added inline comments.May 2 2025, 8:50 AM
misc/compat13x/Makefile
29

If I'm installing compat13x on a 14.x system prior to upgrading to 15.x, I want it to pull in compat14x.

misc/compat14x/pkg-descr
1

I don't mind the change if you also change all the other compatNx ports.

arrowd updated this revision to Diff 154742.May 3 2025, 10:56 AM
arrowd marked 3 inline comments as done.
  • misc/compat*x: Rephrase pkg-descr
Harbormaster completed remote builds in B63852: Diff 154742.May 3 2025, 10:57 AM
des accepted this revision.May 5 2025, 11:30 AM
This revision is now accepted and ready to land.May 5 2025, 11:30 AM
Closed by commit R11:28c3b8a7b9ef: misc/compat14x: Add the port by extracting it out of compat13x (authored by arrowd). · Explain WhyMay 5 2025, 2:40 PM
This revision was automatically updated to reflect the committed changes.
arrowd added a commit: R11:28c3b8a7b9ef: misc/compat14x: Add the port by extracting it out of compat13x.
arrowd added a commit: R11:ccb90462377e: misc/compat13x: Stop installing libmd.so, it is now provided by compat14x.
arrowd added a commit: R11:517d30dd6bbf: misc/compat*x: Rephrase pkg-descr.
markmi_dsl-only.net added a subscriber: markmi_dsl-only.net.May 6 2025, 3:16 AM
markmi_dsl-only.net added inline comments.
misc/compat14x/pkg-plist.aarch64
2

Why no lib32/compat/libmd.so.6 (for armv7 support)?

arrowd added inline comments.May 6 2025, 6:17 AM
misc/compat14x/pkg-plist.aarch64
2

That's an interesting question. The gen-compat.sh script that @bapt wrote only has sets="base lib32" for the amd64 case for some reason.

markmi_dsl-only.net added inline comments.May 6 2025, 7:23 AM
misc/compat14x/pkg-plist.aarch64
2

FYI: lib32 for aarch64 was new in 14.0-RELEASE. It was not in any 13.*-* as I remember.

Revision Contents
Changeset List

PathSize
misc/
1 line
compat13x/
6 lines
2 lines
4 lines
2 lines
compat14x/
compat13x/
10 lines
compat14x/
7 lines
12 lines
1 line
2 lines
1 line

Diff 154607

View Options

misc/Makefile

Loading...
View Options

misc/compat13x/Makefile

Loading...
View Options

misc/compat13x/pkg-plist.aarch64

Loading...
View Options

misc/compat13x/pkg-plist.amd64

Loading...
View Options

misc/compat13x/pkg-plist.i386

Loading...
View Options

misc/compat14x/Makefile

Loading...
View Options

misc/compat14x/distinfo

Loading...
View Options

misc/compat14x/pkg-descr

Loading...
View Options

misc/compat14x/pkg-plist.aarch64

Loading...
View Options

misc/compat14x/pkg-plist.amd64

Loading...
View Options

misc/compat14x/pkg-plist.i386

Loading...