Page MenuHomeFreeBSD

sound: Retire volch
ClosedPublic

Authored by christos on Apr 25 2025, 5:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 28, 10:38 PM
Unknown Object (File)
Sun, Jan 25, 2:49 AM
Unknown Object (File)
Thu, Jan 22, 6:04 PM
Unknown Object (File)
Sat, Jan 17, 9:29 PM
Unknown Object (File)
Fri, Jan 16, 12:46 PM
Unknown Object (File)
Dec 20 2025, 8:18 AM
Unknown Object (File)
Dec 11 2025, 6:01 AM
Unknown Object (File)
Dec 10 2025, 10:44 PM
Subscribers

Details

Summary

volch is a variable used internally in dsp_ioctl_channel() which
corresponds to either priv->rdch or priv->wrch. As a result, priv->volch
is also a pointer to one of those two channels, but is also not used
anywhere outside dsp_ioctl_channel(). Since the operation of figuring
out which channel we want to operate on inside dsp_ioctl_channel() is
cheap enough, retire volch to avoid unnecessary complexity and
confusion.

While here, rename "volch" to just "ch".

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63727
Build 60611: arc lint + arc unit

Event Timeline

sys/dev/sound/pcm/dsp.c
557

Delete this comment too? It's not adding anything anymore.

679

Can't you just pass NULL here?

christos marked 2 inline comments as done.

Address Mark's comments.

This revision is now accepted and ready to land.Apr 27 2025, 1:47 PM
This revision was automatically updated to reflect the committed changes.