Page MenuHomeFreeBSD
Differential D49898

vfs_vnops.c: Fix the named attribute check for open
ClosedPublic
Actions

Authored by rmacklem on Apr 18 2025, 11:27 PM.
Tags
None
Referenced Files
F140709020: D49898.diff
Sat, Dec 27, 3:56 AM
Unknown Object (File)
Wed, Dec 10, 10:47 PM
Unknown Object (File)
Sat, Nov 29, 7:26 PM
Unknown Object (File)
Fri, Nov 28, 9:03 PM
Unknown Object (File)
Fri, Nov 28, 8:30 PM
Unknown Object (File)
Nov 6 2025, 9:11 PM
Unknown Object (File)
Nov 6 2025, 1:59 AM
Unknown Object (File)
Nov 5 2025, 2:22 AM
View All 78 Files
Subscribers
imp
olce

Details

Reviewers
kib
Commits
rGee95e4d02dbd: vfs_vnops.c: Fix the named attribute check for open
Summary

In vn_open_cred(), the correct check for O_NAMEDATTR
was done when O_CREAT was specified, but the file already
exists. (Added by commit 2ec2ba7e232d, which will be listed
as a Fixes: in the commit log message.)

This correct check was not copied to the case where O_CREAT
has not been specified.

This patch fixes this.

Test Plan

Tested with a system where ZFS is patched to handle
named attributes.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rmacklem created this revision.Apr 18 2025, 11:27 PM
Herald added subscribers: olce, imp. · View Herald TranscriptApr 18 2025, 11:27 PM
rmacklem requested review of this revision.Apr 18 2025, 11:27 PM
rmacklem added a comment.Apr 19 2025, 3:22 PM

I now realize that the check for non-named attribute is in
ZFS's VOP_LOOKUP(), so this patch is not really needed,
but I think it is a good "safety belt" to put in.

kib added inline comments.Apr 19 2025, 4:55 PM
sys/kern/vfs_vnops.c.sav
386

Can we introduce a helper to calculate error for both pathes, and avoid code duplication?

rmacklem updated this revision to Diff 153937.Apr 19 2025, 8:51 PM
rmacklem marked an inline comment as done.

Added a helper function, as suggested by kib@.

kib accepted this revision.Apr 19 2025, 10:19 PM
This revision is now accepted and ready to land.Apr 19 2025, 10:19 PM
Closed by commit rGee95e4d02dbd: vfs_vnops.c: Fix the named attribute check for open (authored by rmacklem). · Explain WhyApr 20 2025, 11:20 PM
This revision was automatically updated to reflect the committed changes.
rmacklem added a commit: rGee95e4d02dbd: vfs_vnops.c: Fix the named attribute check for open.

Revision Contents
Changeset List

PathSize
sys/
kern/
vfs_vnops.c.sav
vfs_vnops.c.dotdot
39 lines

Diff 153937

View Options

sys/kern/vfs_vnops.c.sav

Loading...