Differential D5993

Change OpenWRT imported dtsi files
ClosedPublic
Actions

Authored by sgalabov on Apr 19 2016, 8:47 AM.

Details

Reviewers

adrian

Commits

rS298345: Change OpenWRT imported dtsi files

Summary

Change '#include <fbsd-*>' to '/include/ "fbsd-*"' in [rm]t*.dtsi

Basically the pre-import work on OpenWRT's dts/dtsi files boils down to:

for f in `ls [mr]t*.dtsi`; do
printf '\n/include/ "fbsd-$f"\n' >> $f
done

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sgalabov updated this revision to Diff 15310.Apr 19 2016, 8:47 AM

sgalabov retitled this revision from to Change OpenWRT imported dts/dtsi files.

sgalabov updated this object.

sgalabov edited the test plan for this revision. (Show Details)

sgalabov added a reviewer: adrian.

sgalabov set the repository for this revision to rS FreeBSD src repository - subversion.

sgalabov added a project: MIPS.

Herald added a subscriber: imp. · View Herald TranscriptApr 19 2016, 8:47 AM

surely the flash DTS stuff could be modified to probe the flash_ident array, based on the names?

In D5993#127869, @adrian wrote:

surely the flash DTS stuff could be modified to probe the flash_ident array, based on the names?

Sure, I could add w25q128 and en25q64 to mx25l's compat_data instead, but I felt that it would polute mx25l unnecessarily and since it only involves changing these 5 dts files out of over 170, I went for this solution instead...

But if you prefer that I add the 2 new chips to mx25l's compat_data I'll rework this.

I mean, can't we have the ofw probe routine check the normal device list, rather than compat data?

Yeah, let's modify the flash driver instead - I'd rather we stick with almost untouched upstream dts files versus maintaining local differences. It's not a huge burden.

OK. I'll do this tomorrow.