Page MenuHomeFreeBSD

Change OpenWRT imported dtsi files
ClosedPublic

Authored by sgalabov on Apr 19 2016, 8:47 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, May 9, 8:48 AM
Unknown Object (File)
Sat, May 4, 6:33 AM
Unknown Object (File)
Feb 2 2024, 9:10 AM
Unknown Object (File)
Dec 20 2023, 12:49 AM
Unknown Object (File)
Dec 11 2023, 4:39 AM
Unknown Object (File)
Nov 16 2023, 12:59 PM
Unknown Object (File)
Nov 15 2023, 3:34 PM
Unknown Object (File)
Nov 6 2023, 7:40 AM
Subscribers

Details

Summary

Change '#include <fbsd-*>' to '/include/ "fbsd-*"' in [rm]t*.dtsi

Basically the pre-import work on OpenWRT's dts/dtsi files boils down to:

for f in `ls [mr]t*.dtsi`; do
printf '\n/include/ "fbsd-$f"\n' >> $f
done

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sgalabov retitled this revision from to Change OpenWRT imported dts/dtsi files.
sgalabov updated this object.
sgalabov edited the test plan for this revision. (Show Details)
sgalabov added a reviewer: adrian.
sgalabov set the repository for this revision to rS FreeBSD src repository - subversion.
sgalabov added a project: MIPS.

surely the flash DTS stuff could be modified to probe the flash_ident array, based on the names?

surely the flash DTS stuff could be modified to probe the flash_ident array, based on the names?

Sure, I could add w25q128 and en25q64 to mx25l's compat_data instead, but I felt that it would polute mx25l unnecessarily and since it only involves changing these 5 dts files out of over 170, I went for this solution instead...

But if you prefer that I add the 2 new chips to mx25l's compat_data I'll rework this.

I mean, can't we have the ofw probe routine check the normal device list, rather than compat data?

Yeah, let's modify the flash driver instead - I'd rather we stick with almost untouched upstream dts files versus maintaining local differences. It's not a huge burden.

sgalabov updated this object.
sgalabov edited edge metadata.

Update diffs. The only change now is changing '#include <fbsd-*>' to '/include/ "fbsd-*"' in the base SoC dtsi files.

sgalabov retitled this revision from Change OpenWRT imported dts/dtsi files to Change OpenWRT imported dtsi files.Apr 20 2016, 7:07 AM
sgalabov updated this object.
adrian edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2016, 2:15 PM
This revision was automatically updated to reflect the committed changes.