Page MenuHomeFreeBSD

libdtrace: Fix formatting of messages about drops
ClosedPublic

Authored by markj on Apr 15 2025, 6:06 PM.
Tags
None
Referenced Files
F153682356: D49847.id153700.diff
Wed, Apr 22, 9:42 PM
Unknown Object (File)
Mon, Apr 20, 3:39 AM
Unknown Object (File)
Sat, Apr 18, 5:10 PM
Unknown Object (File)
Tue, Apr 7, 5:08 PM
Unknown Object (File)
Sat, Apr 4, 2:07 PM
Unknown Object (File)
Mon, Mar 30, 3:51 PM
Unknown Object (File)
Mon, Mar 30, 7:58 AM
Unknown Object (File)
Mon, Mar 30, 5:33 AM
Subscribers

Details

Reviewers
gnn
domagoj.stolfa_gmail.com
Group Reviewers
DTrace
Summary

I noticed that when a script triggers drops, it generates some nonsense
output when it exits, e.g., "4 -1 dtrace INTERNAL INTERNAL DROP". I
believe this is because dt_oformat_drop() is only supposed to be called
when structured output is enabled.

Fixes: 93f27766a7e1 ("dtrace: Add the 'oformat' libdtrace option")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63528
Build 60412: arc lint + arc unit