libdtrace: Fix formatting of messages about drops
ClosedPublic
Actions

Authored by markj on Tue, Apr 15, 6:06 PM.

Tags

None

Referenced Files

	F115576586: D49847.id.diff
	Fri, Apr 25, 1:52 PM

	Unknown Object (File)
	Wed, Apr 23, 12:57 AM

	Unknown Object (File)
	Wed, Apr 23, 12:57 AM

	Unknown Object (File)
	Wed, Apr 23, 12:57 AM

	Unknown Object (File)
	Wed, Apr 23, 12:57 AM

	Unknown Object (File)
	Wed, Apr 23, 12:57 AM

	Unknown Object (File)
	Sat, Apr 19, 11:42 AM

	Unknown Object (File)
	Fri, Apr 18, 10:10 PM

View All 13 Files

Subscribers

imp

Details

Reviewers

gnn
domagoj.stolfa_gmail.com

Group Reviewers

DTrace

Summary

I noticed that when a script triggers drops, it generates some nonsense
output when it exits, e.g., "4 -1 dtrace INTERNAL INTERNAL DROP". I
believe this is because dt_oformat_drop() is only supposed to be called
when structured output is enabled.

Fixes: 93f27766a7e1 ("dtrace: Add the 'oformat' libdtrace option")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63528
Build 60412: arc lint + arc unit

Event Timeline

markj created this revision.Tue, Apr 15, 6:06 PM

Herald added a reviewer: gnn. · View Herald TranscriptTue, Apr 15, 6:06 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B63528: Diff 153700.Tue, Apr 15, 6:06 PM

markj requested review of this revision.Tue, Apr 15, 6:06 PM

markj added a reviewer: domagoj.stolfa_gmail.com.Tue, Apr 15, 6:06 PM

Yeah, those checks are indeed supposed to be there. Thanks for fixing it!

This revision is now accepted and ready to land.Tue, Apr 15, 6:19 PM

Commit 1bb8b1d7e190d75597d31ab87364a058e8ef8c5b, I forgot to tag the commit.

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

lib/

libdtrace/

common/

dt_aggregate.c

16 lines

dt_consume.c

19 lines

Diff 153700

View Options

cddl/contrib/opensolaris/lib/libdtrace/common/dt_aggregate.c