Differential D6021

Add a pcib_attach_child() method to manage adding the child "pci" device.
ClosedPublic
Actions

Authored by jhb on Apr 20 2016, 2:52 AM.

Tags

None

Referenced Files

	F150816244: D6021.id15668.diff
	Sat, Apr 4, 6:13 AM

	Unknown Object (File)
	Sat, Mar 28, 9:43 AM

	Unknown Object (File)
	Thu, Mar 26, 1:12 AM

	Unknown Object (File)
	Tue, Mar 24, 12:15 AM

	Unknown Object (File)
	Thu, Mar 19, 9:03 PM

	Unknown Object (File)
	Thu, Mar 19, 7:43 AM

	Unknown Object (File)
	Mon, Mar 16, 8:26 PM

	Unknown Object (File)
	Sun, Mar 15, 9:03 AM

Subscribers

Details

Reviewers

jhibbits
imp

Commits

rS298711: Add a pcib_attach_child() method to manage adding the child "pci" device.

Summary

Add a pcib_attach_child() method to manage adding the child "pci" device.

This allows the PCI-PCI bridge driver to save a reference to the child
device in its softc.

Note that this required moving the "pci" device creation out of
acpi_pcib_attach(). Instead, acpi_pcib_attach() is renamed to
acpi_pcib_fetch_prt() as it's sole action now is to fetch the PCI
interrupt routing table.

Test Plan

This has been tested as part of the hotplug patches. Keeping a reference to the child "pci" device allows the pcib driver to attach/detach the device on hotplug events.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3343
Build 3378: arc lint + arc unit

Event Timeline

jhb updated this revision to Diff 15364.Apr 20 2016, 2:52 AM

jhb retitled this revision from to Add a pcib_attach_child() method to manage adding the child "pci" device..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: imp.

Herald added a reviewer: jhibbits. · View Herald TranscriptApr 20 2016, 2:52 AM

vangyzen added a subscriber: vangyzen.Apr 20 2016, 10:18 PM

Closed by commit rS298711: Add a pcib_attach_child() method to manage adding the child "pci" device. (authored by jhb). · Explain WhyApr 27 2016, 4:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

18 lines

acpi_pcib_acpi.c

8 lines

acpi_pcib_pci.c

4 lines

2 lines

pci/

27 lines

2 lines

powerpc/

ofw/

5 lines

sparc64/

pci/

3 lines

Diff 15364

sys/dev/acpica/acpi_pcib.c

Loading...

sys/dev/acpica/acpi_pcib_acpi.c

Loading...

sys/dev/acpica/acpi_pcib_pci.c

Loading...

sys/dev/acpica/acpi_pcibvar.h

Loading...

sys/dev/pci/pci_pci.c

Loading...

sys/dev/pci/pcib_private.h

Loading...

sys/powerpc/ofw/ofw_pcib_pci.c

Loading...

sys/sparc64/pci/ofw_pcib.c

Loading...