Page MenuHomeFreeBSD
Differential D49783

if_iwx: Remove debug logging code
ClosedPublic
Actions

Authored by thj on Apr 11 2025, 3:03 PM.
Tags
None
Referenced Files
F125502400: D49783.id153529.diff
Fri, Aug 8, 11:13 AM
Unknown Object (File)
Tue, Aug 5, 7:47 PM
Unknown Object (File)
Tue, Jul 15, 1:02 PM
Unknown Object (File)
Sat, Jul 12, 4:37 AM
Unknown Object (File)
Jul 9 2025, 2:57 PM
Unknown Object (File)
Jul 7 2025, 11:38 AM
Unknown Object (File)
Jul 5 2025, 6:38 PM
Unknown Object (File)
Jul 4 2025, 5:01 PM
View All 35 Files
Subscribers
bz
imp

Details

Reviewers
jhb
bz
Group Reviewers
wireless
Commits
rG71baab405ef6: iwx: Remove debug logging code
Summary

I added this log as part of an effort to diagnose firmware crashes. I
haven't used it for a while and I'm not sure how useful it is for these
compared to other methods.

Move strings for print mappings into if_iwx_debug.c to reduce their
scope.

Suggested by: bz@

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

thj created this revision.Apr 11 2025, 3:03 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 11 2025, 3:03 PM
thj requested review of this revision.Apr 11 2025, 3:03 PM
Harbormaster completed remote builds in B63462: Diff 153529.Apr 11 2025, 3:03 PM
bz accepted this revision as: bz.Apr 11 2025, 9:58 PM
bz added a subscriber: bz.

No @ at the end of Suggested by: bz@ usually

This revision is now accepted and ready to land.Apr 11 2025, 9:58 PM
Closed by commit rG71baab405ef6: iwx: Remove debug logging code (authored by thj). · Explain WhyApr 14 2025, 8:57 AM
This revision was automatically updated to reflect the committed changes.
thj added a commit: rG71baab405ef6: iwx: Remove debug logging code.

Revision Contents
Changeset List

PathSize
sys/
dev/
iwx/
14 lines
208 lines
301 lines

Diff 153630

View Options

sys/dev/iwx/if_iwx.c

Loading...
View Options

sys/dev/iwx/if_iwx_debug.h

Loading...
View Options

sys/dev/iwx/if_iwx_debug.c

Loading...