Page MenuHomeFreeBSD

elftoolchain: Use ${SRCTOP} for the top of the FreeBSD tree
ClosedPublic

Authored by emaste on Apr 19 2016, 1:13 PM.
Tags
None
Referenced Files
F169618119: D5998.id15315.diff
Wed, Sep 2, 2:14 AM
F169517944: D5998.id15440.diff
Tue, Sep 1, 7:14 PM
Unknown Object (File)
Fri, Aug 28, 11:33 PM
Unknown Object (File)
Thu, Aug 27, 3:13 AM
Unknown Object (File)
Thu, Aug 20, 8:26 PM
Unknown Object (File)
Thu, Aug 20, 8:26 PM
Unknown Object (File)
Thu, Aug 20, 8:25 PM
Unknown Object (File)
Wed, Aug 19, 5:40 PM
Subscribers
None

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from to elftoolchain: Use ${SRCTOP} for the top of the FreeBSD tree.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: ngie, bdrewery.
lib/libdwarf/Makefile
5

Also renamed TOP to ELFTCDIR as used elsewhere in ELF Tool Chain build bits to avoid confusion.

ngie edited edge metadata.
ngie added inline comments.
lib/libdwarf/Makefile
5

I think this is missing a tab.

lib/libelf/Makefile
8

I think this is missing a tab.

83

Isn't . implied?

This revision is now accepted and ready to land.Apr 20 2016, 12:06 AM
lib/libdwarf/Makefile
5

Unfortunately ELFTCDIR is too long and it looks odd with a tab after, unless SRCDIR below gets indented an extra tab, and then PACKAGE= looks out of place:

PACKAGE=lib${LIB}
ELFTCDIR=       ${SRCTOP}/contrib/elftoolchain
SRCDIR=         ${ELFTCDIR}/libdwarf
lib/libelf/Makefile
83

It's needed for < > includes relative to ..

This revision was automatically updated to reflect the committed changes.