Page MenuHomeFreeBSD

libc: tests: fix luacheck warnings in the fortification test generator
ClosedPublic

Authored by kevans on Mar 5 2025, 1:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 16, 7:17 AM
Unknown Object (File)
Dec 24 2025, 1:00 AM
Unknown Object (File)
Dec 11 2025, 7:16 AM
Unknown Object (File)
Dec 5 2025, 11:50 PM
Unknown Object (File)
Nov 17 2025, 10:48 AM
Unknown Object (File)
Nov 7 2025, 3:14 AM
Unknown Object (File)
Nov 3 2025, 4:09 PM
Unknown Object (File)
Oct 25 2025, 2:23 PM
Subscribers

Details

Summary

All of these are simple shadowing that don't need to happen; we're
passing the shadowed value through in every case anyways, just use it
in the closure in a more lua-natural fashion.

While we're here, lint the generator every time we generate tests to
ensure that we don't regress without having to remember to manually
run luacheck.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62759
Build 59643: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Mar 5 2025, 1:34 AM
This revision is now accepted and ready to land.Mar 5 2025, 2:45 AM
lib/libc/tests/secure/Makefile
24

Should it be an error to not have luacheck installed? In general I'd rather be consistent rather than silently disabling some checks depending on the environment.

kevans added inline comments.
lib/libc/tests/secure/Makefile
24

Turning it into an error pre-commit... the generator is still a manual process, I don't see any harm in forcing luacheck to be installed for running it.