Differential D5940

Add sbuf variants ata_cmd_sbuf() and ata_res_sbuf()
ClosedPublic
Actions

Authored by scottl on Apr 13 2016, 6:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 1, 6:55 AM

	Unknown Object (File)
	Mon, Mar 30, 7:25 AM

	Unknown Object (File)
	Sat, Mar 28, 2:05 PM

	Unknown Object (File)
	Tue, Mar 24, 8:45 PM

	Unknown Object (File)
	Sun, Mar 22, 7:16 AM

	Unknown Object (File)
	Sat, Mar 21, 7:18 AM

	Unknown Object (File)
	Sat, Mar 21, 12:34 AM

	Unknown Object (File)
	Sun, Mar 15, 7:04 PM

Subscribers

None

Details

Reviewers

ken
imp
mav

Commits

rS297933: Add sbuf variants ata_cmd_sbuf() and ata_res_sbuf(), and reimplement the

Summary

Add ata_cmd_sbuf() and implement ata_cmd_string() in terms of it. Change
ata_res_sbuf() so that ata_res_string() can be implemented in terms of it.
I'm not happy about this change, but its use seems to be very narrowly
limited, and this change makes the API more consistent.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3251
Build 3284: arc lint + arc unit

Event Timeline

scottl updated this revision to Diff 15168.Apr 13 2016, 6:36 PM

scottl retitled this revision from to Add sbuf variants ata_cmd_sbuf() and ata_res_sbuf().

scottl updated this object.

scottl edited the test plan for this revision. (Show Details)

scottl added reviewers: mav, imp, ken.

imp accepted this revision.Apr 13 2016, 6:46 PM

imp edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2016, 6:46 PM

mav accepted this revision.Apr 13 2016, 7:08 PM

mav edited edge metadata.

Lost a small piece of printf formatting in the last revision, restore it.

This revision now requires review to proceed.Apr 13 2016, 7:53 PM

Looks good!

This revision is now accepted and ready to land.Apr 13 2016, 8:07 PM

Closed by commit rS297933: Add sbuf variants ata_cmd_sbuf() and ata_res_sbuf(), and reimplement the (authored by scottl). · Explain WhyApr 13 2016, 8:10 PM

This revision was automatically updated to reflect the committed changes.

scottl mentioned this in rS297933: Add sbuf variants ata_cmd_sbuf() and ata_res_sbuf(), and reimplement the.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ata/

3 lines

66 lines

2 lines

Diff 15168

sys/cam/ata/ata_all.h

Loading...

sys/cam/ata/ata_all.c

Loading...

sys/cam/cam.c

Loading...