Page MenuHomeFreeBSD
Differential D5939

Extract the users/groups creation into a separate shell script.
ClosedPublic
Actions

Authored by mat on Apr 13 2016, 1:53 PM.
Tags
None
Referenced Files
F134909168: D5939.id15295.diff
Wed, Nov 5, 3:51 AM
F134909166: D5939.id15162.diff
Wed, Nov 5, 3:51 AM
F134909149: D5939.id15163.diff
Wed, Nov 5, 3:51 AM
F134909139: D5939.id.diff
Wed, Nov 5, 3:51 AM
F134909137: D5939.id15159.diff
Wed, Nov 5, 3:51 AM
F134909135: D5939.id15160.diff
Wed, Nov 5, 3:51 AM
F134889773: D5939.diff
Wed, Nov 5, 1:29 AM
Unknown Object (File)
Thu, Oct 30, 9:35 PM
View All Files
Subscribers
antoine
bapt

Details

Reviewers
antoine
Group Reviewers
portmgr
Commits
rP413604: Extract the users/groups creation into a separate shell script.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 3244
Build 3277: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 15159.Apr 13 2016, 1:53 PM
mat retitled this revision from to Extract the users/groups creation into a separate shell script..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
Herald added a reviewer: portmgr. · View Herald TranscriptApr 13 2016, 1:53 PM
mat updated this revision to Diff 15160.Apr 13 2016, 1:56 PM
mat edited edge metadata.
  • No need to run rm twice.
Herald edited edge metadata. · View Herald TranscriptApr 13 2016, 1:56 PM
mat updated this revision to Diff 15162.Apr 13 2016, 3:19 PM
mat edited edge metadata.
  • Add a warning about groups that should be removed too.
Herald edited edge metadata. · View Herald TranscriptApr 13 2016, 3:19 PM
mat updated this revision to Diff 15163.Apr 13 2016, 3:21 PM
mat edited edge metadata.

Include another PR in a commit message.

Herald edited edge metadata. · View Herald TranscriptApr 13 2016, 3:21 PM
antoine requested changes to this revision.Apr 14 2016, 7:20 PM
antoine added a reviewer: antoine.
antoine added a subscriber: antoine.

I believe there is a problem (already existing) in bsd.port.mk:

for a in ${PKGPOSTDEINSTALL}; do \
    [ -f $$a ] && ${CAT} $$a >> ${METADIR}/+POST_DEINSTALL ; \
done ; \
[ -f ${PKGPOSTDEINSTALL} ] && ${CP} ${PKGPOSTDEINSTALL} ${METADIR}/+POST_DEINSTALL; \

the last line will probably fail if there are several words in PKGPOSTDEINSTALL

This revision now requires changes to proceed.Apr 14 2016, 7:20 PM
mat added a subscriber: bapt.Apr 14 2016, 9:13 PM
In D5939#126849, @antoine wrote:

I believe there is a problem (already existing) in bsd.port.mk:

for a in ${PKGPOSTDEINSTALL}; do \
    [ -f $$a ] && ${CAT} $$a >> ${METADIR}/+POST_DEINSTALL ; \
done ; \
[ -f ${PKGPOSTDEINSTALL} ] && ${CP} ${PKGPOSTDEINSTALL} ${METADIR}/+POST_DEINSTALL; \

the last line will probably fail if there are several words in PKGPOSTDEINSTALL

I don't really understand the last line of what you quoted. But I think it can just be removed.

@bapt ?

mat added a comment.Apr 14 2016, 9:26 PM
In D5939#126849, @antoine wrote:

I believe there is a problem (already existing) in bsd.port.mk:

for a in ${PKGPOSTDEINSTALL}; do \
    [ -f $$a ] && ${CAT} $$a >> ${METADIR}/+POST_DEINSTALL ; \
done ; \
[ -f ${PKGPOSTDEINSTALL} ] && ${CP} ${PKGPOSTDEINSTALL} ${METADIR}/+POST_DEINSTALL; \

the last line will probably fail if there are several words in PKGPOSTDEINSTALL

Ok, the last line was a leftover, it's not needed at all, I removed it in rP413316. So that bit is fixed.

Closed by commit rP413604: Extract the users/groups creation into a separate shell script. (authored by mat). · Explain WhyApr 18 2016, 6:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
167 lines
109 lines

Diff 15159

View Options

Mk/Scripts/do-users-groups.sh

Loading...
View Options

Mk/bsd.port.mk

Loading...