Extract the users/groups creation into a separate shell script.

[mat]

• No need to run rm twice.

[mat]

• Add a warning about groups that should be removed too.

[mat]

Include another PR in a commit message.

[antoine]

I believe there is a problem (already existing) in bsd.port.mk:

for a in ${PKGPOSTDEINSTALL}; do \
    [ -f $$a ] && ${CAT} $$a >> ${METADIR}/+POST_DEINSTALL ; \
done ; \
[ -f ${PKGPOSTDEINSTALL} ] && ${CP} ${PKGPOSTDEINSTALL} ${METADIR}/+POST_DEINSTALL; \

the last line will probably fail if there are several words in PKGPOSTDEINSTALL

[mat]

In D5939#126849, @antoine wrote:

I believe there is a problem (already existing) in bsd.port.mk:

for a in ${PKGPOSTDEINSTALL}; do \
    [ -f $$a ] && ${CAT} $$a >> ${METADIR}/+POST_DEINSTALL ; \
done ; \
[ -f ${PKGPOSTDEINSTALL} ] && ${CP} ${PKGPOSTDEINSTALL} ${METADIR}/+POST_DEINSTALL; \

the last line will probably fail if there are several words in PKGPOSTDEINSTALL

I don't really understand the last line of what you quoted. But I think it can just be removed.

@bapt ?

[mat]

In D5939#126849, @antoine wrote:

I believe there is a problem (already existing) in bsd.port.mk:

for a in ${PKGPOSTDEINSTALL}; do \
    [ -f $$a ] && ${CAT} $$a >> ${METADIR}/+POST_DEINSTALL ; \
done ; \
[ -f ${PKGPOSTDEINSTALL} ] && ${CP} ${PKGPOSTDEINSTALL} ${METADIR}/+POST_DEINSTALL; \

the last line will probably fail if there are several words in PKGPOSTDEINSTALL

Ok, the last line was a leftover, it's not needed at all, I removed it in rP413316. So that bit is fixed.