Differential D48996

wlanwds: use a local copy of the ifaddr sockaddr, avoid cast
ClosedPublic
Actions

Authored by adrian on Feb 13 2025, 6:34 PM.

Details

Reviewers

Group Reviewers

wireless

Commits

rG571743bdc6e2: wlanwds: use a local copy of the ifaddr sockaddr, avoid cast

Summary

Using the cast results in alignment errors from LLVM.
Instead use a local copy of the sockaddr.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62650
Build 59534: arc lint + arc unit

Event Timeline

adrian created this revision.Feb 13 2025, 6:34 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 13 2025, 6:34 PM

adrian requested review of this revision.Feb 13 2025, 6:34 PM

adrian added a parent revision: D48616: net80211: update get_sta_info() to only populate isi_txrate for legacy rates.Feb 13 2025, 6:34 PM

adrian added a child revision: D48997: wlanwds: add pidfile support.

Harbormaster completed remote builds in B62429: Diff 150987.Feb 13 2025, 6:35 PM

adrian added a reviewer: wireless.Feb 13 2025, 6:37 PM

adrian added a project: wireless.

Not really requesting changes but I believe an alternate solution

tools/tools/net80211/wlanwds/wlanwds.c
287	;;ifa = ifa->ifa_next
298	Check ifconfig::satosdl and it'll go away :)

This revision now requires changes to proceed.Feb 16 2025, 9:14 PM

adrian added inline comments.Feb 27 2025, 12:18 AM

tools/tools/net80211/wlanwds/wlanwds.c
287	oh wow, why'd I do it like this in 2017? I must've found this in some existing code, aiee.

adrian added inline comments.Feb 27 2025, 12:20 AM

tools/tools/net80211/wlanwds/wlanwds.c
298	oh god why aren't these functions in a library somewhere :P

update

Harbormaster completed remote builds in B62650: Diff 151556.Feb 27 2025, 2:26 AM

adrian edited parent revisions, added: D49148: wlanwds: convert getifaddrs() iteration to use the ifa_next pointer; removed: D48616: net80211: update get_sta_info() to only populate isi_txrate for legacy rates.Feb 27 2025, 2:27 AM

adrian marked an inline comment as done.

adrian added inline comments.

tools/tools/net80211/wlanwds/wlanwds.c
287	fixed in D49148

This revision was not accepted when it landed; it landed in state Needs Review.Feb 28 2025, 2:51 AM

Closed by commit rG571743bdc6e2: wlanwds: use a local copy of the ifaddr sockaddr, avoid cast (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG571743bdc6e2: wlanwds: use a local copy of the ifaddr sockaddr, avoid cast.

Revision Contents
Changeset List

Path

Size

tools/

net80211/

wlanwds/

wlanwds.c

2 lines

Diff 151556

View Options

tools/tools/net80211/wlanwds/wlanwds.c

wlanwds: use a local copy of the ifaddr sockaddr, avoid castClosedPublicActions