Page MenuHomeFreeBSD
Differential D49148

wlanwds: convert getifaddrs() iteration to use the ifa_next pointer
ClosedPublic
Actions

Authored by adrian on Feb 27 2025, 2:25 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, May 12, 5:55 PM
Unknown Object (File)
Tue, May 12, 10:41 AM
Unknown Object (File)
Tue, May 12, 7:18 AM
Unknown Object (File)
Mon, May 11, 9:58 PM
Unknown Object (File)
Thu, May 7, 9:51 PM
Unknown Object (File)
Mon, Apr 27, 1:18 PM
Unknown Object (File)
Apr 23 2026, 6:15 PM
Unknown Object (File)
Apr 23 2026, 12:53 AM
View All 89 Files
Subscribers
imp

Details

Reviewers
None
Group Reviewers
wireless
Commits
rG36347cfbf7ac: wlanwds: convert getifaddrs() iteration to use the ifa_next pointer
Summary

I don't know what I was thinking in 2017 when I wrote this, but
it's very wrong.

Use ifa->ifa_next to iterate, not the array index / pointer arithmetic.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62649
Build 59533: arc lint + arc unit

Event Timeline

adrian created this revision.Feb 27 2025, 2:25 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2025, 2:25 AM
adrian requested review of this revision.Feb 27 2025, 2:25 AM
Harbormaster completed remote builds in B62648: Diff 151554.Feb 27 2025, 2:25 AM
adrian updated this revision to Diff 151555.Feb 27 2025, 2:25 AM

update

Harbormaster completed remote builds in B62649: Diff 151555.Feb 27 2025, 2:25 AM
adrian added a child revision: D48996: wlanwds: use a local copy of the ifaddr sockaddr, avoid cast.Feb 27 2025, 2:27 AM
adrian mentioned this in D48996: wlanwds: use a local copy of the ifaddr sockaddr, avoid cast.
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D49149: wlanwatch: clean up to compile / run.Feb 27 2025, 2:39 AM
adrian removed a child revision: D49149: wlanwatch: clean up to compile / run.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 28 2025, 2:51 AM
Closed by commit rG36347cfbf7ac: wlanwds: convert getifaddrs() iteration to use the ifa_next pointer (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG36347cfbf7ac: wlanwds: convert getifaddrs() iteration to use the ifa_next pointer.

Revision Contents
Changeset List

PathSize
tools/
tools/
net80211/
wlanwds/
2 lines

Diff 151555

View Options

tools/tools/net80211/wlanwds/wlanwds.c

Loading...