Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 62595 Build 59479: arc lint + arc unit
Event Timeline
| sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c | ||
|---|---|---|
| 12996 | This function is called directly in some places, so the patch doesn't compile. For the taskq_dispatch case, I'd introduce a wrapper like: static void
dtrace_enabling_matchall_task(void *args __unused)
{
dtrace_enabling_matchall();
} | |
Comment Actions
Sorry. Too much patch at the same time.
I forgot to cherry-pick the patch from my kcfi work branch.
| sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c | ||
|---|---|---|
| 12998 | ||
Comment Actions
BTW, a question is that it is put inside the opensolaris directory. Should I upstream to illumos? I don't find the counterpart on illumos.
Comment Actions
It's not necessary from my point of view. Our copy of dtrace has diverged from illumos quite a lot over time. It is also not particularly easy to upstream such small patches to illumos unless they fix some concrete bug, in my (limited) experience. You can try of course, I just would not say that it's necessary.