Paths

Table of Contentst

Differential D5930

Allwinner A31/A31S R-GPIO
ClosedPublic
Actions

Authored by manu_bidouilliste.com on Apr 12 2016, 10:33 PM.

Tags

Referenced Files

	F105997013: D5930.diff
	Mon, Dec 23, 4:01 PM

	Unknown Object (File)
	Wed, Dec 11, 10:22 PM

	Unknown Object (File)
	Fri, Dec 6, 7:03 AM

	Unknown Object (File)
	Fri, Dec 6, 4:23 AM

	Unknown Object (File)
	Sat, Nov 30, 8:32 AM

	Unknown Object (File)
	Nov 16 2024, 7:46 AM

	Unknown Object (File)
	Oct 6 2024, 10:11 AM

	Unknown Object (File)
	Oct 3 2024, 10:49 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS298513: Add support for Allwinner A31/A31S R-GPIO (CPUs-PORT) controller.

Summary

Add support for the other gpio controller found in A31/A31S
It need D5580

Test Plan

Apply patch and build kernel, test on Bananapi M2 (A31S)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu_bidouilliste.com updated this revision to Diff 15127.Apr 12 2016, 10:33 PM

manu_bidouilliste.com retitled this revision from to Allwinner A31/A31S R-GPIO.

manu_bidouilliste.com updated this object.

manu_bidouilliste.com edited the test plan for this revision. (Show Details)

manu_bidouilliste.com added a reviewer: ARM.

manu_bidouilliste.com set the repository for this revision to rS FreeBSD src repository - subversion.

manu_bidouilliste.com added a project: ARM.

Herald added subscribers: loos, andrew, imp. · View Herald TranscriptApr 12 2016, 10:33 PM

manu_bidouilliste.com added a parent revision: D5580: ALLWINNER generic config file and A31 kernel config.Apr 12 2016, 10:35 PM

jmcneill added a subscriber: jmcneill.Apr 19 2016, 10:22 PM

jmcneill added inline comments.

sys/arm/allwinner/a10_gpio.c
596	Should this be protected with ifdef SOC_ALLWINNER_xxx ?
sys/arm/allwinner/a31/a31_r_padconf.c
37	#ifdef SOC_ALLWINNER_xxx ?

Protect a31_r_padconf with ifdefs

manu_bidouilliste.com marked 2 inline comments as done.Apr 20 2016, 2:24 AM

jmcneill added inline comments.Apr 20 2016, 8:24 AM

sys/arm/allwinner/a10_gpio.c

As discussed on IRC, we should move the padconf values to compat_data[] ocd_data, so something like:

static struct ofw_compat_data compat_data[] = {
#ifdef SOC_ALLWINNER_A10
    { "allwinner,sun4i-a10-pinctrl",  (uintptr_t)&a10_padconf },
#endif
    ...

and here we can simply do:

sc->padconf = (struct allwinner_padconf *)ofw_bus_search_compatible(dev, compat_data)->ocd_data;

Put the padconf in the compat_data struct.

manu_bidouilliste.com marked an inline comment as done.Apr 21 2016, 7:12 AM

jmcneill added inline comments.Apr 21 2016, 4:52 PM

sys/arm/allwinner/a10_gpio.c
111	Instead of the ifndef below, why don't we just say `#if defined(SOC_ALLWINNER_A31) \|\| defined(SOC_ALLWINNER_A31S)` here? Same for the `extern` above.

manu_bidouilliste.com added inline comments.Apr 21 2016, 4:59 PM

sys/arm/allwinner/a10_gpio.c
111	Because sometimes I'm stupid that's why :) I'll change that

Simplify the inclusion of the r-gpio padconf.

manu_bidouilliste.com marked 2 inline comments as done.Apr 21 2016, 6:47 PM

jmcneill added inline comments.Apr 22 2016, 9:35 AM

sys/arm/allwinner/a10_gpio.c
117	This compat string is duplicated on line 111

Remove duplicate line ...

manu_bidouilliste.com marked an inline comment as done.Apr 22 2016, 9:39 AM

jmcneill accepted this revision.Apr 22 2016, 9:43 AM

jmcneill added a reviewer: jmcneill.

This revision is now accepted and ready to land.Apr 22 2016, 9:43 AM

Closed by commit rS298513: Add support for Allwinner A31/A31S R-GPIO (CPUs-PORT) controller. (authored by jmcneill). · Explain WhyApr 23 2016, 1:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm/

allwinner/

96 lines

a31/

a31_r_padconf.c

62 lines

1 line

Diff 15127

sys/arm/allwinner/a10_gpio.c

Loading...

sys/arm/allwinner/a31/a31_r_padconf.c

Loading...

sys/arm/allwinner/a31/files.a31

Loading...