Allwinner A31/A31S R-GPIO

[manu_bidouilliste.com]

Summary

Add support for the other gpio controller found in A31/A31S
It need D5580

Test Plan

Apply patch and build kernel, test on Bananapi M2 (A31S)

[jmcneill]

sys/arm/allwinner/a10_gpio.c

604

Should this be protected with ifdef SOC_ALLWINNER_xxx ?

sys/arm/allwinner/a31/a31_r_padconf.c

38

#ifdef SOC_ALLWINNER_xxx ?

[manu_bidouilliste.com]

Protect a31_r_padconf with ifdefs

[jmcneill]

sys/arm/allwinner/a10_gpio.c

568

As discussed on IRC, we should move the padconf values to compat_data[] ocd_data, so something like:

static struct ofw_compat_data compat_data[] = {
#ifdef SOC_ALLWINNER_A10
    { "allwinner,sun4i-a10-pinctrl",  (uintptr_t)&a10_padconf },
#endif
    ...

and here we can simply do:

sc->padconf = (struct allwinner_padconf *)ofw_bus_search_compatible(dev, compat_data)->ocd_data;

[manu_bidouilliste.com]

Put the padconf in the compat_data struct.

[jmcneill]

sys/arm/allwinner/a10_gpio.c

111

Instead of the ifndef below, why don't we just say #if defined(SOC_ALLWINNER_A31) || defined(SOC_ALLWINNER_A31S) here? Same for the extern above.

[manu_bidouilliste.com]

sys/arm/allwinner/a10_gpio.c

111

Because sometimes I'm stupid that's why :)
I'll change that

[manu_bidouilliste.com]

Simplify the inclusion of the r-gpio padconf.

[jmcneill]

sys/arm/allwinner/a10_gpio.c

117

This compat string is duplicated on line 111

[manu_bidouilliste.com]

Remove duplicate line ...