Page MenuHomeFreeBSD

linuxkpi: Add `show_fdinfo()` to `struct file_operations`
Needs ReviewPublic

Authored by dumbbell on Wed, Feb 19, 9:36 PM.
Tags
None
Referenced Files
F110757463: D49069.diff
Sat, Feb 22, 5:32 PM
F110747632: D49069.diff
Sat, Feb 22, 2:30 PM
Unknown Object (File)
Thu, Feb 20, 8:41 AM
Unknown Object (File)
Wed, Feb 19, 11:11 PM
Unknown Object (File)
Wed, Feb 19, 11:09 PM
Subscribers

Details

Reviewers
None
Group Reviewers
linuxkpi
Summary

We never call this field but it allows to compile drivers without modifications.

This is used by the DRM drivers for some time, but another change part of the update to Linux 6.8 led to compile them with CONFIG_PROC_FS. This connected code that uses this struct field.

This is part of the update of DRM drivers to Linux 6.8.

Sponsored by: The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dumbbell edited the summary of this revision. (Show Details)
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/fs.h
157

No need for variable names in declarations (remove m and f) also to stay consistent with the rest of the file.

This likely warrants another __FreeBSD_version bump (so maybe do that when all changes are going in together).