linuxkpi: Add `show_fdinfo()` to `struct file_operations`
ClosedPublic
Actions

Authored by dumbbell on Feb 19 2025, 9:36 PM.

Details

Reviewers

Group Reviewers

linuxkpi

Commits

rGc2a591813a9b: linuxkpi: Add `show_fdinfo()` to `struct file_operations`

Summary

We never call this field but it allows to compile drivers without modifications.

This is used by the DRM drivers for some time, but another change part of the update to Linux 6.8 led to compile them with CONFIG_PROC_FS. This connected code that uses this struct field.

This is part of the update of DRM drivers to Linux 6.8.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Feb 19 2025, 9:36 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 19 2025, 9:36 PM

dumbbell requested review of this revision.Feb 19 2025, 9:36 PM

dumbbell edited the summary of this revision. (Show Details)

bz added a subscriber: bz.Feb 22 2025, 12:49 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/fs.h
157	No need for variable names in declarations (remove m and f) also to stay consistent with the rest of the file. This likely warrants another __FreeBSD_version bump (so maybe do that when all changes are going in together).