Page MenuHomeFreeBSD
Differential D48949

syslogd: Fix tests when if_epair is not loaded
ClosedPublic
Actions

Authored by jlduran on Feb 11 2025, 10:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 6:56 PM
Unknown Object (File)
Tue, Mar 25, 6:32 AM
Unknown Object (File)
Sun, Mar 23, 12:06 PM
Unknown Object (File)
Mon, Mar 17, 3:27 PM
Unknown Object (File)
Fri, Mar 14, 3:11 PM
Unknown Object (File)
Feb 23 2025, 11:06 AM
Unknown Object (File)
Feb 21 2025, 6:39 PM
Unknown Object (File)
Feb 15 2025, 9:03 PM
View All 15 Files
Subscribers
imp

Details

Reviewers
emaste
markj
Commits
rG8d9c25c4e171: syslogd: Fix tests when if_epair is not loaded
Summary

Take a cue from vnet.subr and abstract module loading, jail creation and
cleanup.

Note that the way jails are created differs slightly from vnet.subr, to
maintain the current style of the tests.

Reported by: Jenkins

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62394
Build 59278: arc lint + arc unit

Event Timeline

jlduran created this revision.Feb 11 2025, 10:42 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2025, 10:42 PM
jlduran requested review of this revision.Feb 11 2025, 10:42 PM
Harbormaster completed remote builds in B62376: Diff 150863.Feb 11 2025, 10:42 PM
markj added inline comments.Feb 12 2025, 2:06 PM
usr.sbin/syslogd/tests/syslogd_test_common.sh
140

Doesn't this mean we only pass the first optional argument to jail(8)?

jlduran updated this revision to Diff 150904.Feb 12 2025, 2:16 PM
jlduran marked an inline comment as done.

Address suggestions:

  • Accept all arguments (not just the first one) after the jail name
Harbormaster completed remote builds in B62394: Diff 150904.Feb 12 2025, 2:16 PM
markj accepted this revision.Feb 12 2025, 2:18 PM

Thank you very much.

This revision is now accepted and ready to land.Feb 12 2025, 2:18 PM
Closed by commit rG8d9c25c4e171: syslogd: Fix tests when if_epair is not loaded (authored by jlduran). · Explain WhyFeb 12 2025, 2:45 PM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rG8d9c25c4e171: syslogd: Fix tests when if_epair is not loaded.

Revision Contents
Changeset List

PathSize
usr.sbin/
syslogd/
tests/
23 lines
43 lines

Diff 150904

View Options

usr.sbin/syslogd/tests/syslogd_test.sh

Show All 13 Lines
.\" THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR .\" THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
.\" IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, .\" IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
.\" FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE .\" FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
.\" AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER .\" AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
.\" LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, .\" LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
.\" OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN .\" OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
.\" THE SOFTWARE. .\" THE SOFTWARE.
.\" .\"
.Dd January 12, 2024 .Dd February 8, 2024
.Dt MIXER 8 .Dt MIXER 8
.Os .Os
.Sh NAME .Sh NAME
.Nm mixer .Nm mixer
.Nd manipulate soundcard mixer controls .Nd manipulate soundcard mixer controls
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl f Ar device .Op Fl f Ar device
.Op Fl d Ar unit .Op Fl d Ar pcmN | N
.Op Fl os .Op Fl os
.Op Ar dev Ns Op Cm \&. Ns Ar control Ns Op Cm \&= Ns Ar value .Op Ar dev Ns Op Cm \&. Ns Ar control Ns Op Cm \&= Ns Ar value
.Ar ... .Ar ...
.Nm .Nm
.Op Fl d Ar unit
.Op Fl os .Op Fl os
.Fl a .Fl a
.Nm .Nm
.Fl h .Fl h
.Sh DESCRIPTION .Sh DESCRIPTION
The The
.Nm .Nm
utility is used to set and display soundcard mixer device controls. utility is used to set and display soundcard mixer device controls.
.Pp .Pp
The options are as follows: The options are as follows:
.Bl -tag -width "-f device" .Bl -tag -width "-d pcmN | N"
.It Fl a .It Fl a
Print the values for all mixer devices available in the system Print the values for all mixer devices available in the system
.Pq see Sx FILES . .Pq see Sx FILES .
.It Fl d Ar unit .It Fl d Ar pcmN | N
Change the default audio card to Change the default audio card to
.Ar unit . .Ar pcmN ,
The unit has to be an integer value. where N is the unit number (e.g for pcm0, the unit number is 0).
To see what unit values are available, look at the number each mixer device has by running See
.Nm . .Sx EXAMPLES
on how to list all available audio devices in the system.
.It Fl f Ar device .It Fl f Ar device
Open Open
.Ar device .Ar device
as the mixer device as the mixer device
.Pq see Sx FILES . .Pq see Sx FILES .
.It Fl h .It Fl h
Print a help message. Print a help message.
.It Fl o .It Fl o
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines
file, although it does not exist in the filesystem, points to the default file, although it does not exist in the filesystem, points to the default
mixer device and is the file mixer device and is the file
.Nm .Nm
opens when the opens when the
.Fl f Ar device .Fl f Ar device
option has not been specified. option has not been specified.
.El .El
.Sh EXAMPLES .Sh EXAMPLES
List all available audio devices in the system:
.Bd -literal -offset indent
$ mixer -a | grep ^pcm
.Ed
.Pp
Increase the volume for the Increase the volume for the
.Cm vol .Cm vol
device of the first mixer found by 5%: device of the first mixer found by 5%:
.Bd -literal -offset indent .Bd -literal -offset indent
$ mixer vol=+0.05 $ mixer vol=+0.05
.Ed .Ed
.Pp .Pp
Change the volume for the Change the volume for the
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines
View Options

usr.sbin/syslogd/tests/syslogd_test_common.sh

Show All 13 Lines
.\" THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR .\" THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
.\" IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, .\" IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
.\" FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE .\" FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
.\" AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER .\" AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
.\" LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, .\" LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
.\" OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN .\" OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
.\" THE SOFTWARE. .\" THE SOFTWARE.
.\" .\"
.Dd January 12, 2024 .Dd February 8, 2024
.Dt MIXER 8 .Dt MIXER 8
.Os .Os
.Sh NAME .Sh NAME
.Nm mixer .Nm mixer
.Nd manipulate soundcard mixer controls .Nd manipulate soundcard mixer controls
.Sh SYNOPSIS .Sh SYNOPSIS
.Nm .Nm
.Op Fl f Ar device .Op Fl f Ar device
.Op Fl d Ar unit .Op Fl d Ar pcmN | N
.Op Fl os .Op Fl os
.Op Ar dev Ns Op Cm \&. Ns Ar control Ns Op Cm \&= Ns Ar value .Op Ar dev Ns Op Cm \&. Ns Ar control Ns Op Cm \&= Ns Ar value
.Ar ... .Ar ...
.Nm .Nm
.Op Fl d Ar unit
.Op Fl os .Op Fl os
.Fl a .Fl a
.Nm .Nm
.Fl h .Fl h
.Sh DESCRIPTION .Sh DESCRIPTION
The The
.Nm .Nm
utility is used to set and display soundcard mixer device controls. utility is used to set and display soundcard mixer device controls.
.Pp .Pp
The options are as follows: The options are as follows:
.Bl -tag -width "-f device" .Bl -tag -width "-d pcmN | N"
.It Fl a .It Fl a
Print the values for all mixer devices available in the system Print the values for all mixer devices available in the system
.Pq see Sx FILES . .Pq see Sx FILES .
.It Fl d Ar unit .It Fl d Ar pcmN | N
Change the default audio card to Change the default audio card to
.Ar unit . .Ar pcmN ,
The unit has to be an integer value. where N is the unit number (e.g for pcm0, the unit number is 0).
To see what unit values are available, look at the number each mixer device has by running See
.Nm . .Sx EXAMPLES
on how to list all available audio devices in the system.
.It Fl f Ar device .It Fl f Ar device
Open Open
.Ar device .Ar device
as the mixer device as the mixer device
.Pq see Sx FILES . .Pq see Sx FILES .
.It Fl h .It Fl h
Print a help message. Print a help message.
.It Fl o .It Fl o
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines
file, although it does not exist in the filesystem, points to the default file, although it does not exist in the filesystem, points to the default
mixer device and is the file mixer device and is the file
.Nm .Nm
opens when the opens when the
.Fl f Ar device .Fl f Ar device
option has not been specified. option has not been specified.
.El .El
.Sh EXAMPLES .Sh EXAMPLES
List all available audio devices in the system:
.Bd -literal -offset indent
$ mixer -a | grep ^pcm
.Ed
.Pp
Increase the volume for the Increase the volume for the
.Cm vol .Cm vol
device of the first mixer found by 5%: device of the first mixer found by 5%:
.Bd -literal -offset indent .Bd -literal -offset indent
$ mixer vol=+0.05 $ mixer vol=+0.05
.Ed .Ed
.Pp .Pp
Change the volume for the Change the volume for the
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines