net/akhq: Web GUI for Apache Kafka Kafka GUI for Apache Kafka to manage topics, topics data, consumers group, schema registry, connect and more... PR: 274149 Sponsored by: Klara, Inc. Approved by: 0mp (mentor, implicit) Co-authored-by: kiwi Co-authored-by: lwhsu
Details
Details
- Reviewers
0mp lwhsu allanjude - Commits
- R11:2b8ec57a7b7d: net/akhq: Web GUI for Apache Kafka
Tested with poudriere on 14.2
Pet Portclippy and portlint (with a little warning about java, but since Mk/java.mk has change recently portlint is maybe not up to date).
Tested on a jail, the port works and starting correctly
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Hey! Thank you for taking care of this patch.
Here is some late feedback regarding the patch:
- You forgot to add Reviewed by: allanjude
- When using Approved by: 0mp (mentor, implicit) during my absence, please make sure to also secure a Approved by: someportscommitter (ports).
- For Co-authored-by you must make sure to follow the following format: Name Surname <email@example.org. See https://docs.freebsd.org/en/articles/committers-guide/#_include_appropriate_metadata_in_a_footer and https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors for more details.
Otherwise, the patch looks solid! :)
| net/akhq/Makefile | ||
|---|---|---|
| 6 | This should probably be DISTVERSION instead but at this point it's not worth changing that. Note: DISTVERSIONFULL is also handy sometimes. | |
| 10 | COMMENT should not be the name of the port, but something more descriptive. For example:
| |
| 29 | Tip: PREFIX/etc/akhq is essentially ${ETCDIR}. | |
| 33 | You can just add that to PLIST_FILES. See ./net-im/py-matrix-synapse/Makefile for example. | |
| 36 | I suspect that you don't need that if statement. You are installing this port into a stage directory. The config file is not there so you won't override it. | |
| net/akhq/files/akhq.in | ||
| 19 | This should be %%WWWOWN%%. | |
| net/akhq/files/application.yml | ||
| 10 | Question: Is this configuration file coming from upstream? Is it normal for this program to serve on 0.0.0.0 instead of 127.0.0.1? | |