Paths

Table of Contentst

Make crypt(3) thread-safe by utilizing thread-local storage.
Needs ReviewPublic
Actions

Authored by delphij on Feb 5 2025, 6:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 21, 6:30 AM

	Unknown Object (File)
	Mon, Apr 21, 6:15 AM

	Unknown Object (File)
	Sun, Apr 20, 11:26 PM

	Unknown Object (File)
	Sun, Apr 20, 10:14 PM

	Unknown Object (File)
	Sun, Apr 20, 9:25 PM

	Unknown Object (File)
	Sun, Apr 20, 9:07 PM

	Unknown Object (File)
	Thu, Apr 17, 2:46 AM

	Unknown Object (File)
	Apr 10 2025, 10:14 PM

View All 21 Files

Subscribers

None

Details

Reviewers

emaste
imp
jrtc27

Summary

The crypt(3) interface is a wrapper around crypt_r(3) where a global
static storage is passed as data. Modernize the interface by
passing a thread-local storage instead so it is thread-safe.

Test Plan

kyua test lib/libcrypt

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 62267
Build 59151: arc lint + arc unit

Event Timeline

delphij requested review of this revision.Feb 5 2025, 6:14 AM

delphij created this revision.

Harbormaster completed remote builds in B62267: Diff 150515.Feb 5 2025, 6:14 AM

It's still not thread-safe if you pass the return value to another thread, but perhaps that's outside the scope

Revision Contents
Changeset List

Path

Size

lib/

libcrypt/

crypt.3

14 lines

crypt.c

2 lines

Diff 150515

View Options

lib/libcrypt/crypt.3