Differential D5864

Update if_rt to support more SoCs via both FDT and non-FDT
ClosedPublic
Actions

Authored by sgalabov on Apr 6 2016, 3:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 2, 2:46 AM

	Unknown Object (File)
	Sun, Jul 27, 8:59 AM

	Unknown Object (File)
	Sun, Jul 27, 7:34 AM

	Unknown Object (File)
	Sun, Jul 27, 6:12 AM

	Unknown Object (File)
	Sun, Jul 27, 5:46 AM

	Unknown Object (File)
	Sat, Jul 26, 1:11 PM

	Unknown Object (File)
	Sat, Jul 26, 1:14 AM

	Unknown Object (File)
	Jul 7 2025, 2:14 PM

View All 98 Files

Subscribers

Details

Reviewers

ray
adrian

Commits

rS297646: This revision adds support to if_rt for more SoCs.

Summary

This revision adds support to if_rt for more SoCs.

The SoCs I've tried the driver with include the following:
RT3050, RT5350, RT3662, RT3883, MT7620, MT7621, MT7688.
On boards, based on the above SoCs traffic is passing through correctly and the boards survive a flood ping with very little or no drops (drops may be caused elsewhere in my test setup, however).

One issue still remains and needs to be fixed in the future: if_rt does not survive an ifconfig rt0 down/ifconfig rt0 up cycle.
This issue existed before this commit as well, however.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sgalabov updated this revision to Diff 14933.Apr 6 2016, 3:04 PM

sgalabov retitled this revision from to Update if_rt to support more SoCs via both FDT and non-FDT.

sgalabov updated this object.

sgalabov edited the test plan for this revision. (Show Details)

sgalabov added reviewers: adrian, ray.

sgalabov set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2016, 3:04 PM

adrian accepted this revision.Apr 6 2016, 4:28 PM

adrian edited edge metadata.

adrian added inline comments.

sys/dev/rt/if_rt.c
384	We should document these RX descriptor bit fields in a header file and include those definitions here.

This revision is now accepted and ready to land.Apr 6 2016, 4:28 PM

sgalabov added inline comments.Apr 6 2016, 5:38 PM

sys/dev/rt/if_rt.c
384	Oops, this escaped me somehow... I can do this before committing if you don't mind?

Sure thing, go ahead.

Looks good to me too. Thanks Stanislav.

Closed by commit rS297646: This revision adds support to if_rt for more SoCs. (authored by sgalabov). · Explain WhyApr 7 2016, 7:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rt/

114 lines

5 lines

Diff 14933

sys/dev/rt/if_rt.c

Loading...

sys/dev/rt/if_rtvar.h

Loading...